Skip to content

Implement new bindings component for Huawei OBS#1724

Merged
berndverst merged 7 commits into
dapr:masterfrom
jasonlica:huawei-obs-bindings
May 18, 2022
Merged

Implement new bindings component for Huawei OBS#1724
berndverst merged 7 commits into
dapr:masterfrom
jasonlica:huawei-obs-bindings

Conversation

@jasonlica

@jasonlica jasonlica commented May 12, 2022

Copy link
Copy Markdown
Contributor

Description

Huawei OBS is implemented as an output bindings component into the Dapr. This can be a counterpart to the existing AWS S3 bindings component.

Object Storage Service (OBS) provides stable, secure, efficient, and easy-to-use cloud storage that lets you store virtually any volume of unstructured data in any format and access it from anywhere using REST APIs.

See Huawei OBS User Guide for reference.

I will provide the documentation for this component usage later and will raise a PR for that when the PR for this component is being approved.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1718

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@jasonlica
jasonlica requested review from a team as code owners May 12, 2022 19:59
berndverst
berndverst previously approved these changes May 12, 2022
@berndverst

Copy link
Copy Markdown
Member

We need to check why the FOSSA license check is failing before we can merge this PR. I did see that the upstream library is Apache 2.0 so it should not be a concern.

@berndverst berndverst added do-not-merge PR is not ready for merging documentation required This issue needs documentation labels May 12, 2022
@berndverst

Copy link
Copy Markdown
Member

@jasonlica please open the documentation PR for this component and link that PR here. We will only merge this PR after the documentation PR has been opened. Thanks!

@jasonlica

Copy link
Copy Markdown
Contributor Author

@jasonlica please open the documentation PR for this component and link that PR here. We will only merge this PR after the documentation PR has been opened. Thanks!

@berndverst sure, I will create the documentation PR for this component. thanks.

@berndverst

Copy link
Copy Markdown
Member

@jasonlica can you please also address the conflict in the go.mod?

@jasonlica

Copy link
Copy Markdown
Contributor Author

@jasonlica can you please also address the conflict in the go.mod?

@berndverst resolved the conflict. please review, thanks.

Signed-off-by: Bernd Verst <[email protected]>
@jasonlica

Copy link
Copy Markdown
Contributor Author

@jasonlica please open the documentation PR for this component and link that PR here. We will only merge this PR after the documentation PR has been opened. Thanks!

@berndverst sure, I will create the documentation PR for this component. thanks.

@berndverst I have created documentation for this component and linked the PR in the above description. thanks.

@codecov

codecov Bot commented May 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1724 (b804bad) into master (bfd87eb) will increase coverage by 0.38%.
The diff coverage is 36.53%.

@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
+ Coverage   36.37%   36.75%   +0.38%     
==========================================
  Files         166      176      +10     
  Lines       15488    15930     +442     
==========================================
+ Hits         5633     5855     +222     
- Misses       9228     9419     +191     
- Partials      627      656      +29     
Impacted Files Coverage Δ
authentication/azure/auth.go 38.12% <0.00%> (-1.77%) ⬇️
authentication/azure/auth_amqp.go 0.00% <0.00%> (ø)
bindings/azure/cosmosdb/cosmosdb.go 18.00% <ø> (ø)
bindings/azure/eventhubs/eventhubs.go 14.79% <0.00%> (ø)
bindings/cron/cron.go 87.23% <ø> (ø)
bindings/http/http.go 87.87% <ø> (ø)
bindings/huawei/obs/obs_service.go 0.00% <0.00%> (ø)
bindings/kubernetes/kubernetes.go 17.14% <ø> (ø)
bindings/localstorage/localstorage.go 4.95% <0.00%> (-0.17%) ⬇️
internal/component/kafka/consumer.go 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b6b01...b804bad. Read the comment docs.

@berndverst
berndverst merged commit 499f6b2 into dapr:master May 18, 2022
@berndverst

Copy link
Copy Markdown
Member

Thanks for your contribution @jasonlica

@berndverst berndverst removed do-not-merge PR is not ready for merging documentation required This issue needs documentation labels May 18, 2022
@berndverst berndverst added this to the v1.8 milestone May 18, 2022
@jasonlica

Copy link
Copy Markdown
Contributor Author

Thanks for your contribution @jasonlica

@berndverst it is our pleasure! thanks to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a new bindings component for the Huawei OBS

2 participants