secret stores support HuaweiCloud CSMS#1703
Closed
ChenCong0207 wants to merge 5 commits into
Closed
Conversation
ChenCong0207
changed the title
berndverst
added
do-not-merge
berndverst
suggested changes
May 4, 2022
berndverst
left a comment
berndverst
left a comment
Member
There was a problem hiding this comment.
Please sign off on your commit.
Also please open the Docs PR to document this secret store. Once you have opened the docs PR I will merge this.
To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin secret_stores_support_huaweicloud_csms
| secretAccessKey string = "secretAccessKey" | ||
| pageLimit string = "100" | ||
| latestVersion string = "latest" | ||
| versionID string = "version_id" |
Member
There was a problem hiding this comment.
Are you sure you want to name this version_id? All other fields are specified in camelcase. Perhaps versionId would be better? I'll leave it up to you.
Contributor
Author
There was a problem hiding this comment.
@berndverst fully agree with it, thank you for pointing it out. I will update it.
Member
|
Please fix linter failures |
Contributor
Author
|
@berndverst Let me check it and I will back. |
Signed-off-by: Chen Cong <[email protected]>
) * certification test for eventhubs binding Signed-off-by: tanvigour <[email protected]> * modified go.mod and go.sum Signed-off-by: tanvigour <[email protected]> * Add connection string testing Signed-off-by: tanvigour <[email protected]> * iothub testing Signed-off-by: tanvigour <[email protected]> * address feedback and run test Signed-off-by: tanvigour <[email protected]> * Install Azure CLI IOT hub extension Signed-off-by: Bernd Verst <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> * covering all eventhubs test cases Signed-off-by: tanvigour <[email protected]> * dependency changes after go modtidy-all Signed-off-by: tanvigour <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Chen Cong <[email protected]>
Signed-off-by: pigletfly <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Chen Cong <[email protected]>
* Updated to Go 1.18 Signed-off-by: Alessandro (Ale) Segala <[email protected]> * Added go.work file With Go 1.18, this allows gopls (the Go language server used for example in VS Code) to work inside test apps too. See: https://go.dev/doc/tutorial/workspaces Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> * Removed go.work Signed-off-by: ItalyPaleAle <[email protected]> * 💄 Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Chen Cong <[email protected]>
* Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Chen Cong <[email protected]>
ChenCong0207
force-pushed
the
secret_stores_support_huaweicloud_csms
branch
from
May 8, 2022 10:26
566259c to
7ccf914
Compare
Contributor
Author
|
Close this PR and recreate a new one to solve the signoff issue. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add HuaweiCloud Cloud Secret Management Service (CSMS) as a secret component.
https://support.huaweicloud.com/intl/en-us/usermanual-dew/dew_01_9994.html
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[1704]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: