Refactory kafka pubsub components for code reuse#1695
Closed
skyao wants to merge 9 commits into
Closed
Conversation
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
…since in input binding the topics will confiured in metadata Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
…nts-contrib into refactory-kafka-components
7 tasks
Signed-off-by: Sky Ao <[email protected]>
Merged
3 tasks
shubham1172
approved these changes
Apr 29, 2022
shubham1172
reviewed
Apr 29, 2022
shubham1172
reviewed
Apr 29, 2022
| return nil | ||
| type PubSub struct { | ||
| kafka *kafka.Kafka | ||
| topics map[string]bool |
Member
There was a problem hiding this comment.
Do we need a map? Will []string not work?
daixiang0
reviewed
Apr 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
+ Coverage 36.37% 36.53% +0.16%
==========================================
Files 166 173 +7
Lines 15488 15587 +99
==========================================
+ Hits 5633 5694 +61
- Misses 9228 9261 +33
- Partials 627 632 +5
Continue to review full report at Codecov.
|
Member
Author
|
This PR is included in PR So close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactory kafka pubsub components, extract the kafka common code from pubsub component and laster we can reuse them in kafka binding component.
This is just move code from kafka pubsub to internal/kafka and split the common kafka logic and pubsub component api, it should be safe from the view of functionality.
Issue reference
#1305
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: