Skip to content

state store query API: remove preceding '.' in key names#1500

Merged
yaron2 merged 1 commit into
dapr:masterfrom
dmitsh:ds-dot
Feb 11, 2022
Merged

state store query API: remove preceding '.' in key names#1500
yaron2 merged 1 commit into
dapr:masterfrom
dmitsh:ds-dot

Conversation

@dmitsh

@dmitsh dmitsh commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

Description

state store query API: remove preceding '.' in key names

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1490

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@dmitsh
dmitsh requested review from a team as code owners February 11, 2022 22:39
@codecov

codecov Bot commented Feb 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1500 (bc801e5) into master (625f955) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   35.29%   35.29%           
=======================================
  Files         157      157           
  Lines       14241    14242    +1     
=======================================
+ Hits         5026     5027    +1     
  Misses       8692     8692           
  Partials      523      523           
Impacted Files Coverage Δ
bindings/mysql/mysql.go 46.89% <0.00%> (ø)
state/azure/cosmosdb/cosmosdb_query.go 55.05% <100.00%> (ø)
state/mongodb/mongodb_query.go 40.00% <100.00%> (ø)
state/postgresql/postgresql_query.go 59.18% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb659c...bc801e5. Read the comment docs.

@yaron2 yaron2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

statestore query API: remove 'value' prefix from the key names in query JSON

3 participants