Skip to content

feat: add dapr mcpservers cli cmd#1628

Merged
cicoyle merged 8 commits into
dapr:masterfrom
sicoyle:feat/mcp-crd
May 26, 2026
Merged

feat: add dapr mcpservers cli cmd#1628
cicoyle merged 8 commits into
dapr:masterfrom
sicoyle:feat/mcp-crd

Conversation

@sicoyle

@sicoyle sicoyle commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Description

Summary

  • Adds dapr mcpservers -k command to list MCPServer CRD resources in Kubernetes
  • Supports --name, --namespace, --all-namespaces, and -o json/yaml flags
  • Follows the same pattern as dapr components -k and dapr configurations -k

This will fail until my upstream PR here is merged with the clientset changes required for this:
dapr/dapr#9742

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@sicoyle
sicoyle requested review from a team as code owners April 9, 2026 19:42
Copilot AI review requested due to automatic review settings April 9, 2026 19:42
@sicoyle sicoyle mentioned this pull request Apr 9, 2026
3 tasks

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Kubernetes-mode CLI command (dapr mcpservers -k) to list Dapr MCPServer CRD resources, aligning output/flags with existing components and configurations listing patterns.

Changes:

  • Introduces Kubernetes client helpers to list/print MCPServer resources with table and JSON/YAML output.
  • Adds a new dapr mcpservers Cobra command with --name, --namespace, --all-namespaces, and -o flags.
  • Adds unit tests for listing/filtering behavior and endpoint-derived fields (transport/URL).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
pkg/kubernetes/mcpservers.go Implements listing, filtering, table output, and JSON/YAML detail output for MCPServers.
pkg/kubernetes/mcpservers_test.go Adds tests for write path, transport detection, and URL derivation.
cmd/mcpservers.go Adds the new dapr mcpservers CLI command and flags wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/kubernetes/mcpservers.go Outdated
Comment thread pkg/kubernetes/mcpservers.go
Comment thread pkg/kubernetes/mcpservers_test.go
Comment thread cmd/mcpservers.go Outdated
Comment thread cmd/mcpservers.go

@cicoyle cicoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm

Comment thread cmd/mcpservers.go Outdated
Comment thread pkg/kubernetes/mcpservers.go Outdated
@cicoyle
cicoyle merged commit 473697e into dapr:master May 26, 2026
27 checks passed
@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @sicoyle cli-badge Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot

holopin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Congratulations @sicoyle, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmqbf0lef0003kz04av0c79x2

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants