fix flaky standalone e2e by dropping "Exited App successfully" requirement#1605
Conversation
…ement Signed-off-by: Albert Callarisa <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in standalone E2E tests by simplifying the “clean exit” logic in executeAgainstRunningDapr, removing the requirement that output must contain Exited App successfully.
Changes:
- Simplifies the
cmd.Wait()error handling by dropping thehasAppCommand/Exited App successfullygating logic. - Updates exit-validation to instead rely on absence of an “App process exited with error…” message.
- Removes the conditional assertion for
Exited App successfullyfrom the helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@acroca please fix conflicts |
Signed-off-by: Albert Callarisa <[email protected]>
An example of the flakiness here https://github.com/dapr/cli/actions/runs/22751141926/job/65985748435?pr=1604
Fix flaky standalone e2e tests by simplifying the exit-error check in
executeAgainstRunningDapr.