Skip to content

fix: allow explicit disable of placement with empty host (v1.16)#1535

Merged
JoshVanL merged 3 commits into
dapr:release-1.16from
inishchith:fix/disable-placement-when-empty-addr-1.16
Sep 5, 2025
Merged

fix: allow explicit disable of placement with empty host (v1.16)#1535
JoshVanL merged 3 commits into
dapr:release-1.16from
inishchith:fix/disable-placement-when-empty-addr-1.16

Conversation

@inishchith

Copy link
Copy Markdown
Contributor

Description

  • This PR fixes a behavior where passing an explicitly empty placement host address should disable Placement, but instead the runtime still attempted to connect. It also aligns the CLI behavior and help so that users can reliably disable Placement without actors/workflows.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: fixes: dapr/dapr#9000

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@JoshVanL
JoshVanL merged commit 8a2f022 into dapr:release-1.16 Sep 5, 2025
22 of 27 checks passed
javier-aliaga pushed a commit to javier-aliaga/cli that referenced this pull request Sep 10, 2025
…r#1535)

* fix: allow explicit disable of placement with empty host

fixes: dapr/dapr#9000
Signed-off-by: inishchith <[email protected]>

* fix: treat whitespace-only placement/scheduler addresses as empty

Signed-off-by: inishchith <[email protected]>

* fix: move scheduler and placement flags to pointer-aware

Signed-off-by: inishchith <[email protected]>

---------

Signed-off-by: inishchith <[email protected]>
javier-aliaga pushed a commit to javier-aliaga/cli that referenced this pull request Sep 10, 2025
…r#1535)

* fix: allow explicit disable of placement with empty host

fixes: dapr/dapr#9000
Signed-off-by: inishchith <[email protected]>

* fix: treat whitespace-only placement/scheduler addresses as empty

Signed-off-by: inishchith <[email protected]>

* fix: move scheduler and placement flags to pointer-aware

Signed-off-by: inishchith <[email protected]>

---------

Signed-off-by: inishchith <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
JoshVanL pushed a commit to JoshVanL/dapr-cli that referenced this pull request Sep 30, 2025
…r#1535)

* fix: allow explicit disable of placement with empty host

fixes: dapr/dapr#9000
Signed-off-by: inishchith <[email protected]>

* fix: treat whitespace-only placement/scheduler addresses as empty

Signed-off-by: inishchith <[email protected]>

* fix: move scheduler and placement flags to pointer-aware

Signed-off-by: inishchith <[email protected]>

---------

Signed-off-by: inishchith <[email protected]>
cicoyle pushed a commit to cicoyle/cli that referenced this pull request Nov 10, 2025
…r#1535)

* fix: allow explicit disable of placement with empty host

fixes: dapr/dapr#9000
Signed-off-by: inishchith <[email protected]>

* fix: treat whitespace-only placement/scheduler addresses as empty

Signed-off-by: inishchith <[email protected]>

* fix: move scheduler and placement flags to pointer-aware

Signed-off-by: inishchith <[email protected]>

---------

Signed-off-by: inishchith <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants