Fix scheduler standalone CLI address remove on certain versions, edge or dev#1479
Closed
antontroshin wants to merge 3 commits into
Closed
Fix scheduler standalone CLI address remove on certain versions, edge or dev#1479antontroshin wants to merge 3 commits into
antontroshin wants to merge 3 commits into
Conversation
Signed-off-by: Anton Troshin <[email protected]>
Signed-off-by: Anton Troshin <[email protected]>
7 tasks
Signed-off-by: Anton Troshin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #1479 +/- ##
===============================================
Coverage ? 21.32%
===============================================
Files ? 44
Lines ? 5154
Branches ? 0
===============================================
Hits ? 1099
Misses ? 3971
Partials ? 84 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Superseded by #1480 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In standalone mode
scheduler-host-addresswas not set by default to localhost.Working locally on "dev" version was removing this argument from
dapr runcommandIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: