Skip to content

Use non-deprecated flags in List operation#1478

Merged
yaron2 merged 1 commit into
dapr:release-1.15from
yaron2:flags-1
Jan 22, 2025
Merged

Use non-deprecated flags in List operation#1478
yaron2 merged 1 commit into
dapr:release-1.15from
yaron2:flags-1

Conversation

@yaron2

@yaron2 yaron2 commented Jan 22, 2025

Copy link
Copy Markdown
Member

The CLI currently uses a deprecated flag in daprd for max request size and read buffer body. This PR sets the correct flags. The CLI can continue to exist with the user facing --dapr prefix.

@yaron2
yaron2 requested review from a team as code owners January 22, 2025 00:45

@paulyuk paulyuk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches supported migration.
LGTM. Thank you for this, because it makes our tests work.

@yaron2
yaron2 merged commit 953c4a2 into dapr:release-1.15 Jan 22, 2025
@yaron2
yaron2 deleted the flags-1 branch January 22, 2025 06:52
@yaron2

yaron2 commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

@mikeee feel free to release rc.2

paulyuk added a commit to dapr/quickstarts that referenced this pull request Jan 22, 2025
Need RC.2 containing fix for deprecation flags.  see dapr/cli#1478

Signed-off-by: Paul Yuknewicz <[email protected]>
yaron2 added a commit to dapr/quickstarts that referenced this pull request Feb 28, 2025
* fix: configuration/python/http/order-processor/requirements.txt to reduce vulnerabilities


The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-7267250

* fix: pub_sub/python/sdk/order-processor-fastapi/requirements.txt to reduce vulnerabilities


The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-ANYIO-7361842

* helloworld: add terminal to node app for vscode

Signed-off-by: Joël Séguillon <[email protected]>

* chore: bump runtime version to rc.2 (#1126)

Signed-off-by: Mike Nguyen <[email protected]>

* chore: cleanup & unify workflows and bump kind version (#1127)

Signed-off-by: Mike Nguyen <[email protected]>

* Creating Conversation folder

Signed-off-by: Fernando Rocha <[email protected]>

* Modernized and updated Workflow .NET quickstart to use latest best practices and Dapr package (1.15.0 rc01)

Signed-off-by: Whit Waldo <[email protected]>

* Updated Dapr package version to use latest RC02

Signed-off-by: Whit Waldo <[email protected]>

* COnverstaion API

Signed-off-by: Fernando Rocha <[email protected]>

* add python-sdk in cryptography (#1093)

Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Alice Gibbons <[email protected]>

* Fixing Conversation HTTP example for RC5

Signed-off-by: Fernando Rocha <[email protected]>

* Fixing Conversation SDK example for RC5

Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation.go

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update go.mod

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update go.mod

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* fix: updates CLI and runtime version to fix tests (#1138)

Signed-off-by: Mike Nguyen <[email protected]>

* Tests updates

Signed-off-by: Alice Gibbons <[email protected]>

* HTTP csharp jobs quickstart

Signed-off-by: Alice Gibbons <[email protected]>

* Finishing conversation sdk and fixing components path

Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/http/README.md

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* fix: bump python crypto dep to >=1.14

Signed-off-by: Mike Nguyen <[email protected]>

* fix: modify actors/cs test assertion

Signed-off-by: Mike Nguyen <[email protected]>

* fix: define update deps for python wf quickstart

Signed-off-by: Mike Nguyen <[email protected]>

* fix(test): typo in existing quickstart validation

Signed-off-by: Mike Nguyen <[email protected]>

* fix: update python WF dep names

Signed-off-by: Mike Nguyen <[email protected]>

* Update global.env with Dapr CLI 1.15.0-rc.2

Need RC.2 containing fix for deprecation flags.  see dapr/cli#1478

Signed-off-by: Paul Yuknewicz <[email protected]>

* Update conversation/go/sdk/dapr.yaml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/http/dapr.yaml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/sdk/dapr.yaml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Updating sleep and timeout times

Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/sdk/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/http/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/http/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/sdk/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/http/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Comversation README improvements

Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/http/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/sdk/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/go/sdk/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* removing files from PR

Signed-off-by: Fernando Rocha <[email protected]>

* Csharp conversation quickstarts

Signed-off-by: Alice Gibbons <[email protected]>

* Python Jobs  API - HTTP quickstart

Signed-off-by: Fernando Rocha <[email protected]>

* Version bump (dapr rc8, cli rc3 and python sdk 1.15.0rc2) (#1148)

* Updates to python sdk 1.15.0rc2

Signed-off-by: Elena Kolevska <[email protected]>

* Test fix

Signed-off-by: Elena Kolevska <[email protected]>

* test fix

Signed-off-by: Elena Kolevska <[email protected]>

* Bumps runtime and cli versions

Signed-off-by: Elena Kolevska <[email protected]>

* Bumps runtime to rc8

Signed-off-by: Elena Kolevska <[email protected]>

---------

Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>

* Python Conversation http Quickstart (#1150)

* Python Conversation API - HTTP quickstart

Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/python/http/dapr.yaml

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update conversation/python/http/dapr.yaml

Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

---------

Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>

* Added Quickstart for Javascript Jobs  HTTP api (#1134)

* Added Quickstart for Javascript Jobs HTTP api

Signed-off-by: Constantin Chirila <[email protected]>

* Updated Read me for Jobs quickstart

Signed-off-by: Constantin Chirila <[email protected]>

* Updated Package json with the right services names and correct ports

Signed-off-by: Constantin Chirila <[email protected]>

* Updated JS Jobs README to clear dotnet processes

Signed-off-by: Constantin Chirila <[email protected]>

* Reordered props in dapr.yaml

Signed-off-by: Constantin Chirila <[email protected]>

---------

Signed-off-by: Constantin Chirila <[email protected]>
Co-authored-by: Constantin Chirila <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>

* Fix inconsistent dapr.yaml and appIDs (#1152)

* Fix inconsistent multi-app run files

Signed-off-by: Marc Duiker <[email protected]>

* Rename appID for consistency

Signed-off-by: Marc Duiker <[email protected]>

* Update appID for consistency

Signed-off-by: Marc Duiker <[email protected]>

* fix appID

Signed-off-by: Marc Duiker <[email protected]>

* Fix appID

Signed-off-by: Marc Duiker <[email protected]>

* Remove schedulerHostAddress

Signed-off-by: Marc Duiker <[email protected]>

---------

Signed-off-by: Marc Duiker <[email protected]>

* RC 9 and CLI RC 4 (#1153)

Signed-off-by: Alice Gibbons <[email protected]>

* Conversation JS HTTP Quickstart (#1154)

* Added Quickstart for Javascript Conversation HTTP api

Signed-off-by: Constantin Chirila <[email protected]>

* Minor change

Signed-off-by: Constantin Chirila <[email protected]>

* Updated Readme

Signed-off-by: Constantin Chirila <[email protected]>

* Removed redundant check on response

Signed-off-by: Constantin Chirila <[email protected]>

* Updated Readme

Signed-off-by: Constantin Chirila <[email protected]>

---------

Signed-off-by: Constantin Chirila <[email protected]>
Co-authored-by: Constantin Chirila <[email protected]>

* splitting header

Signed-off-by: Fernando Rocha <[email protected]>

* updating to runtime version 1.15.0-rc.10 and cli version 1.15.0-rc.5

Signed-off-by: Paul Yuknewicz <[email protected]>

* removing flask, fixing print statements

Signed-off-by: Fernando Rocha <[email protected]>

* readme

Signed-off-by: Fernando Rocha <[email protected]>

* gitignore

Signed-off-by: Fernando Rocha <[email protected]>

* Update jobs/python/http/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* Update jobs/python/http/README.md

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>

* removing debug logs

Signed-off-by: Fernando Rocha <[email protected]>

* Update jobs/python/http/README.md

Signed-off-by: Alice Gibbons <[email protected]>

* chore:RC 11

Signed-off-by: Alice Gibbons <[email protected]>

* removing localhost scheduler and gitignore

Signed-off-by: Fernando Rocha <[email protected]>

* removing unecessary parsing step

Signed-off-by: Fernando Rocha <[email protected]>

* Update .NET workflow quickstart

Signed-off-by: Marc Duiker <[email protected]>

* Update Java Workflow sample

Signed-off-by: Marc Duiker <[email protected]>

* Update Python Quickstart

Signed-off-by: Marc Duiker <[email protected]>

* Fix event name

Signed-off-by: Marc Duiker <[email protected]>

* Update JavaScrrip WF Quickstart with new naming, input and output.

Signed-off-by: Marc Duiker <[email protected]>

* Update Python WF quickstart to wait_for_workflow_completion

Signed-off-by: Marc Duiker <[email protected]>

* Clean up Python

Signed-off-by: Marc Duiker <[email protected]>

* update Go Workflow to use WaitForCompletion

Signed-off-by: Marc Duiker <[email protected]>

* Add clarification about sending/receiving events

Signed-off-by: Marc Duiker <[email protected]>

* All validations are working

Signed-off-by: Marc Duiker <[email protected]>

* Fixed python conversation quickstart

* Add link to raise event

Signed-off-by: Marc Duiker <[email protected]>

* release: bump go examples to rc1

Signed-off-by: Mike Nguyen <[email protected]>

* updating dapr version to 1.15.0-rc.18 (#1168)

Signed-off-by: Fernando Rocha <[email protected]>

* Conversation quickstarts updates - Python and Go (#1169)

* Adds python conversation api sdk quickstart. Updates python sdk version. Updates parameter name in conversation quickstart in Go.

Signed-off-by: Elena Kolevska <[email protected]>

* Fixes .net http quickstart for Conversation API

Signed-off-by: Elena Kolevska <[email protected]>

* rename

Signed-off-by: Elena Kolevska <[email protected]>

* Fixes js conversation quickstart

Signed-off-by: Elena Kolevska <[email protected]>

* Older dependency

Signed-off-by: Elena Kolevska <[email protected]>

* Sets up a clean virtual environment for every quickstart

Signed-off-by: Elena Kolevska <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>

* Adds uvicorn in requirements.txt

Signed-off-by: Elena Kolevska <[email protected]>

* Runs the install step

Signed-off-by: Elena Kolevska <[email protected]>

---------

Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>

* Updated Dapr .NET SDK package to use latest protos - no other changes needed to the example (#1170)

Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]>

* Update global.env

Signed-off-by: Yaron Schneider <[email protected]>

* Bumps python sdk to 1.15.0

Signed-off-by: Elena Kolevska <[email protected]>

---------

Signed-off-by: Joël Séguillon <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Alice Gibbons <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Constantin Chirila <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Alice Gibbons <[email protected]>
Signed-off-by: Yaron Schneider <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Joël Séguillon <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Co-authored-by: Fernando Rocha <[email protected]>
Co-authored-by: Whit Waldo <[email protected]>
Co-authored-by: Kent (Chia-Hao), Hsu <[email protected]>
Co-authored-by: Fernando Rocha <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Co-authored-by: Constantin Chirila <[email protected]>
Co-authored-by: Constantin Chirila <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
yaron2 added a commit that referenced this pull request Mar 14, 2025
* use non-deprecated flags in List operation (#1478)

Signed-off-by: yaron2 <[email protected]>

* Scheduler: set broadcast address to localhost:50006 in selfhosted (#1480)

* Scheduler: set broadcast address to localhost:50006 in selfhosted

Signed-off-by: joshvanl <[email protected]>

* Set schedulder override flag for edge and dev

Signed-off-by: joshvanl <[email protected]>

---------

Signed-off-by: joshvanl <[email protected]>

* Fix scheduler broadcast address for windows (#1481)

Signed-off-by: Anton Troshin <[email protected]>

* Remove deprecated flags (#1482)

* remove deprecated flags

Signed-off-by: yaron2 <[email protected]>

* update Dapr version in tests

Signed-off-by: yaron2 <[email protected]>

---------

Signed-off-by: yaron2 <[email protected]>

* Fix daprsystem configuration retrieval when renewing certificates (#1486)

The issue found when similar resource were installed in k8s that use the name "configurations".
In this case the knative's "configurations.serving.knative.dev/v1" was the last in the list and the command returned the error
`Error from server (NotFound): configurations.serving.knative.dev "daprsystem" not found`

Signed-off-by: Anton Troshin <[email protected]>

* fix: arguments accept units (#1490)

* fix: arguments accept units
`max-body-size` and `read-buffer-size` now accept units as defined in the docs.

Fixes #1489

Signed-off-by: Mike Nguyen <[email protected]>

* chore: gofumpt

Signed-off-by: Mike Nguyen <[email protected]>

* refactor: modify logic to comply with vetting

Signed-off-by: Mike Nguyen <[email protected]>

* chore: gofumpt -w .

Signed-off-by: Mike Nguyen <[email protected]>

* refactor: set defaults
`max-body-size` is defaulted to 4Mi
`request-buffer-size` is defaulted to 4Ki

This is inline with the runtime.

Signed-off-by: Mike Nguyen <[email protected]>

* fix: set defaults in run and annotate

Signed-off-by: Mike Nguyen <[email protected]>

* chore: gofumpt

Signed-off-by: Mike Nguyen <[email protected]>

* refactor: exit with error rather than panic

Co-authored-by: Anton Troshin <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>

---------

Signed-off-by: Mike Nguyen <[email protected]>
Co-authored-by: Anton Troshin <[email protected]>

* Fix scheduler pod count for 1.15 version when testing master and latest (#1492)

Signed-off-by: Anton Troshin <[email protected]>

* Fix podman CI (#1493)

* Fix podman CI
Update to podman 5.4.0

Signed-off-by: Anton Troshin <[email protected]>

* fix --cpus flag

Signed-off-by: Anton Troshin <[email protected]>

---------

Signed-off-by: Anton Troshin <[email protected]>

* Fix dapr upgrade command incorrectly detecting HA mode for new version 1.15 (#1494)

* Fix dapr upgrade command detecting HA mode for new version 1.15
The issue is that the scheduler by default uses 3 replicas, which incorrectly identified non-HA install as HA.

Signed-off-by: Anton Troshin <[email protected]>

* Fix e2e

Signed-off-by: Anton Troshin <[email protected]>

---------

Signed-off-by: Anton Troshin <[email protected]>

* Fix scheduler address for dapr run with file on Windows (#1497)

Signed-off-by: Anton Troshin <[email protected]>

* release: test upgrade/downgrade for 1.13/1.14/1.15 + mariner (#1491)

* release: test upgrade/downgrade for 1.13/1.14/1.15 + mariner

Signed-off-by: Mike Nguyen <[email protected]>

* fix: version skews

Co-authored-by: Anton Troshin <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>

* Update tests/e2e/upgrade/upgrade_test.go

Accepted

Co-authored-by: Anton Troshin <[email protected]>
Signed-off-by: Yaron Schneider <[email protected]>

* Update tests/e2e/upgrade/upgrade_test.go

Co-authored-by: Anton Troshin <[email protected]>
Signed-off-by: Yaron Schneider <[email protected]>

* Fix downgrade issue from 1.15 by deleting previous version scheduler pods
Update 1.15 RC to latest RC.18

Signed-off-by: Anton Troshin <[email protected]>

* Fix downgrade 1.15 to 1.13 scenario with 0 scheduler pods

Signed-off-by: Anton Troshin <[email protected]>

* increase update test timeout to 60m and update latest version to 1.15

Signed-off-by: Anton Troshin <[email protected]>

* fix httpendpoint tests cleanup and checks

Signed-off-by: Anton Troshin <[email protected]>

* make sure matrix runs appropriate tests, every matrix ran the same tests

Signed-off-by: Anton Troshin <[email protected]>

* skip TestKubernetesRunFile on HA

Signed-off-by: Anton Troshin <[email protected]>

* fix skip TestKubernetesRunFile on HA

Signed-off-by: Anton Troshin <[email protected]>

* update to latest dapr 1.15.2

Signed-off-by: Anton Troshin <[email protected]>

* add logs when waiting for pod deletion

Signed-off-by: Anton Troshin <[email protected]>

---------

Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Yaron Schneider <[email protected]>
Signed-off-by: Anton Troshin <[email protected]>
Co-authored-by: Anton Troshin <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Anton Troshin <[email protected]>

* Fix dapr init test latest version retrieval (#1500)

Lint

Signed-off-by: Anton Troshin <[email protected]>

* Fix downgrade stuck (#1501)

* Fix goroutine channel leaks and ensure proper cleanup in tests

Signed-off-by: Anton Troshin <[email protected]>

* Add artificial delay before deleting scheduler pods during downgrade

Signed-off-by: Anton Troshin <[email protected]>

* Add timeout to helm upgrade tests, they are being stuck sometime for 5+ minutes

Signed-off-by: Anton Troshin <[email protected]>

* bump helm.sh/helm/v3 to v3.17.1

Signed-off-by: Anton Troshin <[email protected]>

---------

Signed-off-by: Anton Troshin <[email protected]>

---------

Signed-off-by: yaron2 <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Signed-off-by: Anton Troshin <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Yaron Schneider <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants