fix perfsprint linter error#1438
Conversation
Signed-off-by: KentHsu <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
|
||
| // url for dashboard after port forwarding. | ||
| webURL := fmt.Sprintf("http://%s", net.JoinHostPort(dashboardHost, fmt.Sprint(portForward.LocalPort))) //nolint: perfsprint | ||
| webURL := fmt.Sprintf("http://%s", net.JoinHostPort(dashboardHost, strconv.Itoa(portForward.LocalPort))) |
There was a problem hiding this comment.
| webURL := fmt.Sprintf("http://%s", net.JoinHostPort(dashboardHost, strconv.Itoa(portForward.LocalPort))) | |
| webURL := "http://" + net.JoinHostPort(dashboardHost, strconv.Itoa(portForward.LocalPort)) |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@KentHsu could you please apply the suggested change? It'll fix the lint error. TY! |
Signed-off-by: KentHsu <[email protected]>
|
Hi @antontroshin , it's updated based on your suggestion. Please let me know if there's other issues blocking this PR. Thank you. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@holopin-bot @KentHsu Here's a digital badge as a small token of appreciation. |
|
Congratulations @KentHsu, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmi4f0f7b000ejw04egffqlrg This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
6 participants
Description
Removed
//nolint: perfsprintdirective and fixed all perfsprint linter errorIssue reference
Please reference the issue this PR will close: #1374
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: