arm64 friendly IPFS container#119
Merged
pablomendezroyo merged 1 commit intoFeb 19, 2024
Merged
Conversation
Signed-off-by: garyschulte <[email protected]>
pablomendezroyo
approved these changes
Nov 30, 2023
pablomendezroyo
left a comment
pablomendezroyo
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! @3alpha would you be able to test it in arm=
pablomendezroyo
left a comment
pablomendezroyo
left a comment
Contributor
There was a problem hiding this comment.
@dappnodedev do u have an arm device to test this implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The binary used for fs-repo-migrations is currently amd64 only. This means that IPFS containers on arm64 platforms fail when trying to execute an x86 binary, leading to a container fail/restart loop.
related to #104
Approach
This tweak pulls arch-specific binaries by mapping the output of uname -m to the relevant arch tag.
Test instructions
build and run this container on arm64 machines like rock5 and MacOS M* machines.