Address Clippy 1.73 lints on Deneb branch (sigp#4810)

jimmygchen · michaelsproul · web-flow · commit 4ad7e157329f · 2023-10-06T12:23:57.000+05:30
* Address Clippy 1.73 lints (sigp#4809) ## Proposed Changes Fix Clippy lints enabled by default in Rust 1.73.0, released today. * Address Clippy 1.73 lints. --------- Co-authored-by: Michael Sproul <michael@sigmaprime.io>
diff --git a/beacon_node/beacon_chain/src/blob_verification.rs b/beacon_node/beacon_chain/src/blob_verification.rs
@@ -451,7 +451,7 @@ pub struct KzgVerifiedBlob<T: EthSpec> {
 
 impl<T: EthSpec> PartialOrd for KzgVerifiedBlob<T> {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.blob.partial_cmp(&other.blob)
+        Some(self.cmp(other))
     }
 }
 
diff --git a/beacon_node/beacon_chain/src/eth1_finalization_cache.rs b/beacon_node/beacon_chain/src/eth1_finalization_cache.rs
@@ -67,7 +67,7 @@ impl CheckpointMap {
     pub fn insert(&mut self, checkpoint: Checkpoint, eth1_finalization_data: Eth1FinalizationData) {
         self.store
             .entry(checkpoint.epoch)
-            .or_insert_with(Vec::new)
+            .or_default()
             .push((checkpoint.root, eth1_finalization_data));
 
         // faster to reduce size after the fact than do pre-checking to see
diff --git a/beacon_node/beacon_chain/src/historical_blocks.rs b/beacon_node/beacon_chain/src/historical_blocks.rs
@@ -172,20 +172,17 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
         let signature_set = signed_blocks
             .iter()
             .zip_eq(block_roots)
-            .filter_map(|(block, block_root)| {
-                (block_root != self.genesis_block_root).then(|| {
-                    block_proposal_signature_set_from_parts(
-                        block,
-                        Some(block_root),
-                        block.message().proposer_index(),
-                        &self.spec.fork_at_epoch(block.message().epoch()),
-                        self.genesis_validators_root,
-                        |validator_index| {
-                            pubkey_cache.get(validator_index).cloned().map(Cow::Owned)
-                        },
-                        &self.spec,
-                    )
-                })
+            .filter(|&(_block, block_root)| (block_root != self.genesis_block_root))
+            .map(|(block, block_root)| {
+                block_proposal_signature_set_from_parts(
+                    block,
+                    Some(block_root),
+                    block.message().proposer_index(),
+                    &self.spec.fork_at_epoch(block.message().epoch()),
+                    self.genesis_validators_root,
+                    |validator_index| pubkey_cache.get(validator_index).cloned().map(Cow::Owned),
+                    &self.spec,
+                )
             })
             .collect::<Result<Vec<_>, _>>()
             .map_err(HistoricalBlockError::SignatureSet)
diff --git a/beacon_node/execution_layer/src/test_utils/execution_block_generator.rs b/beacon_node/execution_layer/src/test_utils/execution_block_generator.rs
@@ -371,7 +371,7 @@ impl<T: EthSpec> ExecutionBlockGenerator<T> {
         let block_hash = block.block_hash();
         self.block_hashes
             .entry(block.block_number())
-            .or_insert_with(Vec::new)
+            .or_default()
             .push(block_hash);
         self.blocks.insert(block_hash, block);
 
diff --git a/beacon_node/http_api/src/standard_block_rewards.rs b/beacon_node/http_api/src/standard_block_rewards.rs
@@ -5,8 +5,8 @@ use beacon_chain::{BeaconChain, BeaconChainTypes};
 use eth2::lighthouse::StandardBlockReward;
 use std::sync::Arc;
 use warp_utils::reject::beacon_chain_error;
-//// The difference between block_rewards and beacon_block_rewards is the later returns block
-//// reward format that satisfies beacon-api specs
+/// The difference between block_rewards and beacon_block_rewards is the later returns block
+/// reward format that satisfies beacon-api specs
 pub fn compute_beacon_block_rewards<T: BeaconChainTypes>(
     chain: Arc<BeaconChain<T>>,
     block_id: BlockId,
diff --git a/beacon_node/lighthouse_network/src/peer_manager/mod.rs b/beacon_node/lighthouse_network/src/peer_manager/mod.rs
@@ -1055,7 +1055,7 @@ impl<TSpec: EthSpec> PeerManager<TSpec> {
                         Subnet::Attestation(_) => {
                             subnet_to_peer
                                 .entry(subnet)
-                                .or_insert_with(Vec::new)
+                                .or_default()
                                 .push((*peer_id, info.clone()));
                         }
                         Subnet::SyncCommittee(id) => {
diff --git a/beacon_node/lighthouse_network/src/peer_manager/peerdb/score.rs b/beacon_node/lighthouse_network/src/peer_manager/peerdb/score.rs
@@ -330,13 +330,15 @@ impl Eq for Score {}
 
 impl PartialOrd for Score {
     fn partial_cmp(&self, other: &Score) -> Option<std::cmp::Ordering> {
-        self.score().partial_cmp(&other.score())
+        Some(self.cmp(other))
     }
 }
 
 impl Ord for Score {
     fn cmp(&self, other: &Score) -> std::cmp::Ordering {
-        self.partial_cmp(other).unwrap_or(std::cmp::Ordering::Equal)
+        self.score()
+            .partial_cmp(&other.score())
+            .unwrap_or(std::cmp::Ordering::Equal)
     }
 }
 
diff --git a/beacon_node/operation_pool/src/attestation_storage.rs b/beacon_node/operation_pool/src/attestation_storage.rs
@@ -151,14 +151,8 @@ impl<T: EthSpec> AttestationMap<T> {
             indexed,
         } = SplitAttestation::new(attestation, attesting_indices);
 
-        let attestation_map = self
-            .checkpoint_map
-            .entry(checkpoint)
-            .or_insert_with(AttestationDataMap::default);
-        let attestations = attestation_map
-            .attestations
-            .entry(data)
-            .or_insert_with(Vec::new);
+        let attestation_map = self.checkpoint_map.entry(checkpoint).or_default();
+        let attestations = attestation_map.attestations.entry(data).or_default();
 
         // Greedily aggregate the attestation with all existing attestations.
         // NOTE: this is sub-optimal and in future we will remove this in favour of max-clique
diff --git a/beacon_node/store/src/memory_store.rs b/beacon_node/store/src/memory_store.rs
@@ -48,7 +48,7 @@ impl<E: EthSpec> KeyValueStore<E> for MemoryStore<E> {
         self.col_keys
             .write()
             .entry(col.as_bytes().to_vec())
-            .or_insert_with(HashSet::new)
+            .or_default()
             .insert(key.to_vec());
         Ok(())
     }
diff --git a/consensus/types/src/blob_sidecar.rs b/consensus/types/src/blob_sidecar.rs
@@ -38,7 +38,7 @@ impl BlobIdentifier {
 
 impl PartialOrd for BlobIdentifier {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.index.partial_cmp(&other.index)
+        Some(self.cmp(other))
     }
 }
 
@@ -109,7 +109,7 @@ impl<E: EthSpec> From<BlobSidecar<E>> for BlindedBlobSidecar {
 
 impl<T: EthSpec> PartialOrd for BlobSidecar<T> {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.index.partial_cmp(&other.index)
+        Some(self.cmp(other))
     }
 }
 
diff --git a/validator_client/src/attestation_service.rs b/validator_client/src/attestation_service.rs
@@ -193,7 +193,7 @@ impl<T: SlotClock + 'static, E: EthSpec> AttestationService<T, E> {
             .into_iter()
             .fold(HashMap::new(), |mut map, duty_and_proof| {
                 map.entry(duty_and_proof.duty.committee_index)
-                    .or_insert_with(Vec::new)
+                    .or_default()
                     .push(duty_and_proof);
                 map
             });
diff --git a/validator_client/src/duties_service/sync.rs b/validator_client/src/duties_service/sync.rs
@@ -163,7 +163,7 @@ impl SyncDutiesMap {
 
         committees_writer
             .entry(committee_period)
-            .or_insert_with(CommitteeDuties::default)
+            .or_default()
             .init(validator_indices);
 
         // Return shared reference

Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ pub struct KzgVerifiedBlob<T: EthSpec> {`
`451`	`451`
`452`	`452`	`impl<T: EthSpec> PartialOrd for KzgVerifiedBlob<T> {`
`453`	`453`	`fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {`
`454`		`- self.blob.partial_cmp(&other.blob)`
	`454`	`+ Some(self.cmp(other))`
`455`	`455`	`}`
`456`	`456`	`}`
`457`	`457`
Original file line number	Diff line number	Diff line change
`@@ -1055,7 +1055,7 @@ impl<TSpec: EthSpec> PeerManager<TSpec> {`
`1055`	`1055`	`Subnet::Attestation(_) => {`
`1056`	`1056`	`subnet_to_peer`
`1057`	`1057`	`.entry(subnet)`
`1058`		`- .or_insert_with(Vec::new)`
	`1058`	`+ .or_default()`
`1059`	`1059`	`.push((*peer_id, info.clone()));`
`1060`	`1060`	`}`
`1061`	`1061`	`Subnet::SyncCommittee(id) => {`
Original file line number	Diff line number	Diff line change
`@@ -330,13 +330,15 @@ impl Eq for Score {}`
`330`	`330`
`331`	`331`	`impl PartialOrd for Score {`
`332`	`332`	`fn partial_cmp(&self, other: &Score) -> Option<std::cmp::Ordering> {`
`333`		`- self.score().partial_cmp(&other.score())`
	`333`	`+ Some(self.cmp(other))`
`334`	`334`	`}`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`impl Ord for Score {`
`338`	`338`	`fn cmp(&self, other: &Score) -> std::cmp::Ordering {`
`339`		`- self.partial_cmp(other).unwrap_or(std::cmp::Ordering::Equal)`
	`339`	`+ self.score()`
	`340`	`+ .partial_cmp(&other.score())`
	`341`	`+ .unwrap_or(std::cmp::Ordering::Equal)`
`340`	`342`	`}`
`341`	`343`	`}`
`342`	`344`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ impl<E: EthSpec> KeyValueStore<E> for MemoryStore<E> {`
`48`	`48`	`self.col_keys`
`49`	`49`	`.write()`
`50`	`50`	`.entry(col.as_bytes().to_vec())`
`51`		`- .or_insert_with(HashSet::new)`
	`51`	`+ .or_default()`
`52`	`52`	`.insert(key.to_vec());`
`53`	`53`	`Ok(())`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ impl BlobIdentifier {`
`38`	`38`
`39`	`39`	`impl PartialOrd for BlobIdentifier {`
`40`	`40`	`fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {`
`41`		`- self.index.partial_cmp(&other.index)`
	`41`	`+ Some(self.cmp(other))`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`
`@@ -109,7 +109,7 @@ impl<E: EthSpec> From<BlobSidecar<E>> for BlindedBlobSidecar {`
`109`	`109`
`110`	`110`	`impl<T: EthSpec> PartialOrd for BlobSidecar<T> {`
`111`	`111`	`fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {`
`112`		`- self.index.partial_cmp(&other.index)`
	`112`	`+ Some(self.cmp(other))`
`113`	`113`	`}`
`114`	`114`	`}`
`115`	`115`