Skip to content

Conversation

@transmissions11
Copy link
Contributor

@transmissions11 transmissions11 commented Oct 30, 2021

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

Copy link
Contributor

@jennypollack jennypollack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-xo
Copy link
Contributor

d-xo commented Nov 9, 2021

fine with this in general, would be great to have a test though, perhaps something structured in a similar way to test_custom_solc_json?

@transmissions11
Copy link
Contributor Author

fine with this in general, would be great to have a test though, perhaps something structured in a similar way to test_custom_solc_json?

done!

@jennypollack jennypollack merged commit 0cad2d2 into dapphub:master Nov 11, 2021
@transmissions11 transmissions11 deleted the gas-snapshot-dev branch November 11, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants