fix create with 1559 bug #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
approved these changes
Sep 18, 2021
Contributor
d-xo
left a comment
d-xo
left a comment
There was a problem hiding this comment.
Don't really understand why the fix works, but the test passes so lgtm I guess
| tx = types.NewTx(&types.DynamicFeeTx{ | ||
| Nonce: nonce, | ||
| To: &common.Address{}, | ||
| To: nil, |
Contributor
There was a problem hiding this comment.
curious what the difference is
Member
Author
There was a problem hiding this comment.
Based on @hexonaut err report I'm guessing common.Address{} is the zero address, which is not the same as not having an address which is needed for creates. There was a comment in geth that led me to believe this is the rught way to do it, and it seems to work in the test
Contributor
There was a problem hiding this comment.
ah ok yeah. I can also see this reading through the signer code in geth (e.g. here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist