hevm: no whitespace in invariant replay data #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
commented
Sep 12, 2021
MrChico
reviewed
Sep 14, 2021
Fixes #722. For some obscure reason related to bash array expansion, the whitespace in the invariant replay data ended up being passed to hevm as `' '` (i.e. two quotes with a space). I don't know why bash adds these extra quotes, but we can just ignore this problem by never including whitespace in replay strings...
d-xo
force-pushed
the
fix-dapp-replay
branch
from
4a51706 to
7993963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #722, or at least side steps around it 😬
The issue is that bash was inserting single quotes around whitespace in the replay strings for some obscure reason I do not understand. This pr just makes it so that hevm does not print whitespace in replay strings...
Checklist