Add error logging

dwillcocks · dwillcocks · commit d5a92a0348d5 · 2021-04-27T20:31:48.000+01:00
diff --git a/internal/exporter/exporter.go b/internal/exporter/exporter.go
@@ -114,6 +114,8 @@ func (e *Exporter) speedtest(ch chan<- prometheus.Metric) bool {
 			server.Country,
 			fmt.Sprintf("%f", server.Distance),
 		)
+	} else {
+		log.Errorf("failed to carry out ping test: %s", err.Error())
 	}
 
 	if err := server.DownloadTest(false); err == nil {
@@ -130,6 +132,8 @@ func (e *Exporter) speedtest(ch chan<- prometheus.Metric) bool {
 			server.Country,
 			fmt.Sprintf("%f", server.Distance),
 		)
+	} else {
+		log.Errorf("failed to carry out download test: %s", err.Error())
 	}
 
 	if err := server.UploadTest(false); err == nil {
@@ -146,6 +150,8 @@ func (e *Exporter) speedtest(ch chan<- prometheus.Metric) bool {
 			server.Country,
 			fmt.Sprintf("%f", server.Distance),
 		)
+	} else {
+		log.Errorf("failed to carry out upload test: %s", err.Error())
 	}
 
 	return true

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,8 @@ func (e *Exporter) speedtest(ch chan<- prometheus.Metric) bool {`
`114`	`114`	`server.Country,`
`115`	`115`	`fmt.Sprintf("%f", server.Distance),`
`116`	`116`	`)`
	`117`	`+ } else {`
	`118`	`+ log.Errorf("failed to carry out ping test: %s", err.Error())`
`117`	`119`	`}`
`118`	`120`
`119`	`121`	`if err := server.DownloadTest(false); err == nil {`
`@@ -130,6 +132,8 @@ func (e *Exporter) speedtest(ch chan<- prometheus.Metric) bool {`
`130`	`132`	`server.Country,`
`131`	`133`	`fmt.Sprintf("%f", server.Distance),`
`132`	`134`	`)`
	`135`	`+ } else {`
	`136`	`+ log.Errorf("failed to carry out download test: %s", err.Error())`
`133`	`137`	`}`
`134`	`138`
`135`	`139`	`if err := server.UploadTest(false); err == nil {`
`@@ -146,6 +150,8 @@ func (e *Exporter) speedtest(ch chan<- prometheus.Metric) bool {`
`146`	`150`	`server.Country,`
`147`	`151`	`fmt.Sprintf("%f", server.Distance),`
`148`	`152`	`)`
	`153`	`+ } else {`
	`154`	`+ log.Errorf("failed to carry out upload test: %s", err.Error())`
`149`	`155`	`}`
`150`	`156`
`151`	`157`	`return true`