-
Notifications
You must be signed in to change notification settings - Fork 19
Windows / Linux Support #56
Description
I've been testing out astro-editor on a Windows environment, and it seems like you/your LLMs have generally made good programming decisions that abstract away platform-dependent code for Tauri to handle cross-platform. Enough so that without any modifications, I'm able to get the app to build and launch as a native Windows executable.
I would love to see Windows added as an officially supported platform to the release framework. But even with the app running, there are certain small incompatibilities that would need to be addressed.
One thing I noticed were how the app binds shortcuts like the command palette to the Meta key. On Windows, additional handling has to be added to avoid Windows overriding the meta key (for example, Windows + P opens up the "Project my Screen" toolbar instead of the command palette).
Another bug I noticed is that opening the preferences menu (Can be done via Ctrl + , without any code changes on Windows) immediately crashes the app because get_available_ides returns an empty list (even with IDEs installed). Because an empty string is passed for the radix SelectItem in the event that the list is empty, this causes a runtime exception. So I'd also consider this a ts bug.
PS: Your README.md says "(Cmd + K)" opens the command palette - I assume you meant Cmd + P?
All that said, this tool looks fantastic and I'd love to use it for my own Astro blog - thanks Danny!