Repository navigation
Conversation
ksylvan
requested changes
Nov 1, 2026
- Extract vendor configuration warning formatting into one shared variable. - Reuse captured test output across warning content assertions.
ksylvan
approved these changes
Nov 1, 2026
ksylvan
left a comment
ksylvan
left a comment
Collaborator
There was a problem hiding this comment.
Thank you. LGTM. Made a minor refactoring fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this Pull Request (PR) does
When a configured vendor fails initialization, show its name and the configuration error on stderr even when debug logging is off. Missing credentials for unused vendors remain quiet. For example, a LiteLLM
http://10.1.2.3:4000/v1endpoint rejected by the existing URL policy now explains why the vendor was skipped. The HTTPS and explicit LAN opt-in rules are unchanged.A regression test uses the real LiteLLM client for a rejected configured endpoint, an unconfigured provider, and a valid HTTPS endpoint. The first case fails on the unchanged source; all three pass with the fix. It also checks that the API key is absent from the diagnostic.
Validation with Go 1.26.10:
go test -count=1 ./...passed.go test -race -count=1 ./internal/core ./internal/plugins/...passed.go test -race -count=1 ./internal/server/...passed.go vet ./..., the CI modernization analyzer,gofmt, andgit diff --checkpassed.nix flake checkwas not run. No live provider calls were made.Generated and included
cmd/generate_changelog/incoming/2321.txtwithgo run ./cmd/generate_changelog --incoming-pr 2321 --push=false.After localizing the unconfigured-vendor debug message, fork CI passes for
8fece94: full tests, race tests, the modernization analyzer,nix flake check, and the Windows domain tests. Upstream GitHub Actions still awaits maintainer approval.AI assistance: OpenAI Codex assisted with investigation, implementation, and local validation.
Related issues
Fixes #2311.
Screenshots
Not applicable; the change is a stderr diagnostic.