Skip to content

Made compatible with new osrm::engine::api::ResultT#17

Open
akashihi wants to merge 1 commit intodaniel-j-h:masterfrom
akashihi:fbsupport
Open

Made compatible with new osrm::engine::api::ResultT#17
akashihi wants to merge 1 commit intodaniel-j-h:masterfrom
akashihi:fbsupport

Conversation

@akashihi
Copy link
Copy Markdown
Collaborator

Closes #11

Closes #5548

@daniel-j-h
Copy link
Copy Markdown
Owner

If we merge these changes in we fix compilation against libosrm master but break compilation against stable releases and past libosrm releases. I the following steps moving forward:

  • the osrm folks make a proper release
  • we conditionally compile for their old / new api
  • libosrmc can then be kept api and abi compatible

@akashihi
Copy link
Copy Markdown
Collaborator Author

Ok, let's wait for OSRM release

@akashihi
Copy link
Copy Markdown
Collaborator Author

OSRM new version is released, should this one be merged?

@daniel-j-h
Copy link
Copy Markdown
Owner

@akashihi I'm no longer involved with osrm and/or this library. If you want, I can give you commit access to this repo. so you are not blocked by me not being responsive here.

If we can keep the API/ABI stable here, that would be my number one goal. The implementation is free to change. But then we should conditionally compile the now code. What I mean is

  • if the user has the libosrm C++ headers for 5.23+ we need to compile with the new ResultT changes
  • if the user has the libosrm C++ headers for <5.23+ we need to compile with the old interface

or we say we only support 5.23+ from now on, but this breaks out understanding of ABI/API compatibility across OSRM versions.

@akashihi
Copy link
Copy Markdown
Collaborator Author

Not that i'm really working on OSRM, but i think i'm obliged to fix that incompatibility, cause i caused it. I'll check if i can maintain compatibility by using some metaprogramming, but in any case plan B will be to use simple preprocessor for that.

PS Yes, write access will definitely help.

@daniel-j-h
Copy link
Copy Markdown
Owner

Coolio! I've added you as a collaborator to this repository 🙇

@akashihi
Copy link
Copy Markdown
Collaborator Author

Thank you! I'll try to find sometime for that issue in December

@daniel-j-h daniel-j-h mentioned this pull request Jan 5, 2021
@mster429
Copy link
Copy Markdown

Hi, can we get this pull request merged ? @daniel-j-h

@daniel-j-h
Copy link
Copy Markdown
Owner

Please read the conversation, we can not just merge it, it would break compilation against previous releases.

The osrm folks have changed their api and we need to conditionally compile against the old or new api now.

Until this is done, we can not merge this pull request.

@mster429
Copy link
Copy Markdown

Got it. Thanks for your quick response @daniel-j-h

@hogan-chu
Copy link
Copy Markdown

hogan-chu commented May 25, 2022

Hello is there any improvement un this commt? I want to process this repository for recent osrm version
For not use https
Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build library due to upstream libosrm API breakage libosrm interface broken due to public API changes

4 participants