Repository navigation
Commit 123bb39
fix(session): cap retry attempts and individual retry waits
SessionRetry.policy() retried retryable errors (429/529/overloaded) forever:
no attempt cap and no bound on per-attempt sleep, so persistent provider
failures kept sessions in 'retry' status indefinitely and hard quota limits
(retry-after of hours/days) put sessions into multi-hour silent slumber.
- add RETRY_MAX_ATTEMPTS = 3, checked at the top of the policy() step;
overridable per call via opts.maxAttempts
- add RETRY_MAX_WAIT = 60s: every computed wait is capped (Math.min), so a
6h retry-after burns its remaining attempts in minutes and surfaces
session.error instead of slumbering. Capping (vs aborting) keeps retry
status updates flowing, tolerates legitimate ~60-120s retry-after values,
and bounds the uncapped backoff on the headers-without-retry-hints path.
- hoist the pure delay() computation out of the Effect.gen block
- tests: cap honored, maxAttempts override, 6h retry-after capped with
status still published, 61s retry-after not aborted
Fixes anomalyco#21960. Supersedes the auto-closed anomalyco#26369 by also addressing the
hard-quota slumber gap raised in its review comments.
Co-Authored-By: Claude Fable 5 <[email protected]>1 parent 9976269 commit 123bb39
2 files changed
Lines changed: 89 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
30 | 36 | | |
31 | 37 | | |
32 | 38 | | |
| |||
177 | 183 | | |
178 | 184 | | |
179 | 185 | | |
| 186 | + | |
180 | 187 | | |
181 | 188 | | |
182 | 189 | | |
| 190 | + | |
183 | 191 | | |
184 | 192 | | |
185 | 193 | | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
186 | 198 | | |
187 | | - | |
188 | 199 | | |
189 | 200 | | |
190 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
120 | 196 | | |
121 | 197 | | |
122 | 198 | | |
| |||
0 commit comments