Skip to content

chore: minor package bumps#1475

Merged
rebelchris merged 4 commits intomainfrom
chore-package-updates
Oct 15, 2023
Merged

chore: minor package bumps#1475
rebelchris merged 4 commits intomainfrom
chore-package-updates

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented Oct 14, 2023

Did some minor version bumps.

@rebelchris rebelchris requested review from a team and idoshamun as code owners October 14, 2023 07:57
@rebelchris
Copy link
Copy Markdown
Contributor Author

rebelchris commented Oct 14, 2023

Decided to remove fastify bump due to build error.

node_modules/fastify/types/instance.d.ts:146:3 - error TS1169: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.

146   [Symbol.asyncDispose](): Promise<undefined>;
      ~~~~~~~~~~~~~~~~~~~~~

node_modules/fastify/types/instance.d.ts:146:11 - error TS2339: Property 'asyncDispose' does not exist on type 'SymbolConstructor'.

146   [Symbol.asyncDispose](): Promise<undefined>;
              ~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/fastify/types/instance.d.ts:146

@rebelchris rebelchris mentioned this pull request Oct 14, 2023
Closed
2 tasks
@rebelchris
Copy link
Copy Markdown
Contributor Author

rebelchris commented Oct 15, 2023

Apparently they did add a eslint disable, will give it a try when they open the new release.

fastify/fastify@24fffff

fastify/fastify#5094 (comment)

idoshamun
idoshamun approved these changes Oct 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@idoshamun idoshamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@rebelchris
Copy link
Copy Markdown
Contributor Author

rebelchris commented Oct 15, 2023

Actually team Fastify was super fast and solved it fastify/fastify#5094
So now this is also updated

@rebelchris rebelchris merged commit fa429f0 into main Oct 15, 2023
@rebelchris rebelchris deleted the chore-package-updates branch October 15, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idoshamun idoshamun idoshamun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebelchris @idoshamun