ci: Update config file #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cimg/node docker image supercedes the legacy CircleCI Node.js image, circleci/node. Early 2020, CircleCI released smaller, faster, more deterministic images: https://circleci.com/blog/announcing-our-next-generation-convenience-images-smaller-faster-more-deterministic/ The node images can be found here: https://circleci.com/developer/images/image/cimg/node. The intention of this commit is to optimise the build see: https://circleci.com/blog/tips-for-optimizing-docker-builds/
Member
|
Hey @NdagiStanley, That's awesome! Thanks for letting me know about it. |
Changed the environment value from list to map. Reference: https://circleci.com/docs/2.0/configuration-reference/#environment
Contributor
Author
|
@idoshamun I've updated the PR and I'm glad the build passes. |
Member
|
Thank you! I shall apply these changes in my other projects as well 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates CircleCI config file:
environmentvalue from list to mapAdditional context
Update docker image
The
cimg/nodedocker image supercedes the legacy CircleCI Node.js image,circleci/node.Early 2020, CircleCI released smaller, faster, more deterministic images. The node images can be found here. The intention of this commit is to optimise the build.
change
environmentvalue from list to mapReference