Rename the Find in Files function to Replace in Files and then build Replace in Files#913
Merged
dail8859 merged 34 commits intodail8859:masterfrom Jan 11, 2026
Merged
Conversation
Still learning Qt C++
Should fix problems with squeezing
Owner
|
My apologies. I was reviewing this and did not mean to merge it. The part that I do not like about this PR is that it does not use any of the underlying functionality (regex...which I know does not work great, extended mode, match case, whole word only, etc) which will cause confusion to users expecting it to work exactly the same as the normal replace functionality to files that are opened. |
Contributor
Author
|
We can always fix it though, thanks for feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I renamed the branch which caused #906 to close. I've reopened it here.