Fix multi-instance file path passing#852
Conversation
|
Thanks for the PR! Could you provide a set of steps of the issue you are having? That way I can verify the code changes and try to reproduce it on Windows. |
|
Also on the primary instance if you open the |
|
Steps to reproduce issue:
|
|
👍 |
|
Log from the affected version: Log from this version (with the home name censored): |
|
Frankly the change to use a Set instead of the list was unnecessary. If you ever have a command line with enough files that you can measure a performance improvement, you're using it wrong. |
|
Honestly you are completely right. I was testing out some other things with that at the time and tried to wrap it up late at night and definitely the way it is implemented is not ideal for the 99.99% case. I tend to not trust user input but as a certain point you just tell the user "don't do that". |
--------- Co-authored-by: Yordan Gigov <[email protected]> Co-authored-by: dail8859 <[email protected]>
I tried opening a file through the console while I had an instance running, but the primary instance looked for it in its own working directory.
Not sure if this code is up to standard, but it works on Ubuntu 24. I haven't written in C++ in about 13 years.