[Feature request] Copy Search results #224#596
Conversation
Adds a button to the Search Results dock to copy the contents to the clipboard
dail8859
left a comment
dail8859
left a comment
There was a problem hiding this comment.
Few minor changes for now. Haven't had a chance to compile/run/test these but it all seems relevant.
|
I'll be busy for the next week or so but will get back to this. Appreciate the PR! |
button renamed in GUI, also changed from automatic connection to a connect.
|
Visually the code changes look fine. Once I get a chance I'll compile the code and do some testing. |
|
I pushed some changes. I'm sure there's room for improvement, especially when compared to Notepad++'s implementation...but perfection is the enemy of progress. I redid the button layout to make it a bit more extensible in the future if needed. Also redid how it built the string...I believe that will minimize the number of QString allocations on the heap. Also using There's also one other small quirk I found with it but doubt anyone will ever find it...and the fix isn't obvious...so I'll leave it alone :) If all looks good to you I'll merge this in. |
|
Nice changes, looking good thanks! |
|
Thanks again for the PR! |
Closes dail8859#224 --------- Co-authored-by: dail8859 <[email protected]>
2 participants
Adds a button to the Search Results dock to copy the contents to the clipboard