Skip to content

docs: fix double-negative in comment in internal/runtime/condition.go#2026

Merged
yottahmd merged 1 commit intodagucloud:mainfrom
kuishou68:fix/issue-2025-comment-double-negative
Apr 22, 2026
Merged

docs: fix double-negative in comment in internal/runtime/condition.go#2026
yottahmd merged 1 commit intodagucloud:mainfrom
kuishou68:fix/issue-2025-comment-double-negative

Conversation

@kuishou68
Copy link
Copy Markdown
Contributor

@kuishou68 kuishou68 commented Apr 22, 2026 •
edited by coderabbitai Bot
Loading

Summary

Fixes a confusing double-negative comment in internal/runtime/condition.go.

Change

Before:

// Error message for the case not all condition was not met

After:

// Error message for when not all conditions are met

Explanation

The original comment has two issues:

  1. Double-negative: "not all condition was not met" — the two negatives cancel each other, making the sentence mean the opposite of the intent.
  2. Singular/plural: "condition" should be "conditions" since this relates to multiple conditions.

The fix makes the comment clear and grammatically correct.

Closes #2025

Summary by CodeRabbit

  • Documentation
    • Improved clarity of internal documentation comments.

@kuishou68
docs: fix double-negative in comment in condition.go
49ff918 
The comment '// Error message for the case not all condition was not met'
contained a double-negative ('not ... not met') making it confusing.
Also fix 'condition' (singular) to 'conditions' (plural) for clarity.

New comment: '// Error message for when not all conditions are met'

Closes dagucloud#2025

Signed-off-by: Cocoon-Break <[email protected]>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 525497f7-45b4-4098-bd71-581adbedc512

📥 Commits

Reviewing files that changed from the base of the PR and between 81369ff and 49ff918.

📒 Files selected for processing (1)
  • internal/runtime/condition.go
📝 Walkthrough

Walkthrough

A comment in internal/runtime/condition.go was updated to fix a double-negative construction and grammar. The text "case not all condition was not met" was changed to "when not all conditions are met," improving clarity without affecting any code logic or behavior.

Changes

Cohort / File(s) Summary
Documentation
internal/runtime/condition.go		 Fixed double-negative in comment for ErrMsgOtherConditionNotMet constant; clarified phrasing and corrected singular "condition" to plural "conditions."

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: fixing a double-negative in a comment in the specified file.
Linked Issues check ✅ Passed The code change successfully addresses all objectives from issue #2025: removes the double-negative, fixes the singular/plural mismatch, and updates the comment as specified.
Out of Scope Changes check ✅ Passed The PR contains only the intended comment fix with no additional unrelated changes; all modifications align directly with the requirements in issue #2025.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kuishou68 kuishou68 mentioned this pull request Apr 22, 2026
Closed
yottahmd
yottahmd approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@yottahmd yottahmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the comment!

@yottahmd yottahmd merged commit 8ab4328 into dagucloud:main Apr 22, 2026
9 of 10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yottahmd yottahmd yottahmd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: fix double-negative in comment in internal/runtime/condition.go

2 participants

@kuishou68 @yottahmd