test(e2e): add distributed stack Playwright harness#1996
Merged
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds Playwright-based end-to-end testing: build/test Makefile targets, Playwright config and scripts, a local distributed E2E stack runner, E2E helpers/fixtures, many Playwright test suites, and minor license/build-related code adjustments. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (12)
Makefile (1)
362-364: Reusecp-assetshere to avoid copy-step drift.
test-e2ecurrently duplicates asset copy logic already defined incp-assets.♻️ Proposed refactor
- `@rm` -f ${FE_ASSETS_DIR}/* - `@cp` ${FE_BUILD_DIR}/* ${FE_ASSETS_DIR} + @$(MAKE) cp-assets🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 362 - 364, The test-e2e target duplicates the asset copy steps; remove the explicit "@rm -f ${FE_ASSETS_DIR}/*" and "@cp ${FE_BUILD_DIR}/* ${FE_ASSETS_DIR}" lines and instead invoke the existing cp-assets target (e.g., call "$(MAKE) cp-assets" or add cp-assets as a prerequisite for the test-e2e recipe) so asset copying is centralized in the cp-assets target.ui/e2e/auth-permissions.spec.ts (2)
73-79: AddremoteNodequery parameter to API call.Per coding guidelines, all API calls must include the
remoteNodeparameter to route requests to the correct node in multi-node deployments.♻️ Proposed fix
- const startResponse = await request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/start`, { + const startResponse = await request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/start?remoteNode=local`, { headers: { Authorization: `Bearer ${viewerToken}`, 'Content-Type': 'application/json', }, data: {}, });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/auth-permissions.spec.ts` around lines 73 - 79, The POST call that sets startResponse (request.post in the test) is missing the required remoteNode query parameter; update the request URL used in the request.post for `/api/v1/dags/${encodeURIComponent(fileName)}/start` to include `?remoteNode=<nodeId>` (or interpolate the test's existing remote node variable) so the call routes correctly, and keep the existing headers/authorization (Authorization: `Bearer ${viewerToken}`) and data payload unchanged.
1-11: Missing GPL v3 license header.Per coding guidelines, source files must have GPL v3 license headers managed via
make addlicense.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/auth-permissions.spec.ts` around lines 1 - 11, The file auth-permissions.spec.ts is missing the GPL v3 license header; run the repository license tool (make addlicense) or insert the GPL v3 header at the top of the file so the header precedes the imports (ensure it appears before the import lines referencing helpers like createUser, loginViaAPI, loginViaUI, uniqueName, etc.), then commit the updated file so the test uses the standard license header.ui/e2e/scheduler-recovery.spec.ts (1)
1-11: Missing GPL v3 license header.Per coding guidelines, source files must have GPL v3 license headers managed via
make addlicense. This file is missing the required header.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/scheduler-recovery.spec.ts` around lines 1 - 11, This file is missing the required GPL v3 license header; run the repository tool to add it (execute `make addlicense`) or insert the standard GPL v3 header at the top of the file so it precedes the imports (ensure it appears above the existing symbols like listDAGRuns, loadStack, loginViaAPI, startService, stopService, uniqueName, waitForRunStatus, writeLocalDAG), then commit the updated file.ui/e2e/helpers/e2e.ts (4)
1-4: Missing GPL v3 license header.Per coding guidelines, source files must have GPL v3 license headers managed via
make addlicense.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/helpers/e2e.ts` around lines 1 - 4, This file is missing the GPL v3 license header; add the standard GPL v3 header comment at the very top of the file (above the existing import lines such as "import { expect... }" and other imports) by running the repository license tool (make addlicense) or inserting the canonical GPL v3 header, then stage/commit the change so the file includes the required license header.
223-238: AddremoteNodequery parameter tostartDAGhelper.Per coding guidelines, all API calls must include the
remoteNodeparameter. This helper is missing it.♻️ Proposed fix
export async function startDAG( request: APIRequestContext, token: string, fileName: string, - body: Record<string, unknown> = {} + body: Record<string, unknown> = {}, + remoteNode: string = 'local' ): Promise<string> { - const response = await request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/start`, { + const response = await request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/start?remoteNode=${encodeURIComponent(remoteNode)}`, { headers: authHeaders(token), data: body, });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/helpers/e2e.ts` around lines 223 - 238, The startDAG helper is missing the required remoteNode query parameter; modify the startDAG function signature to accept a remoteNode: string parameter (e.g., startDAG(request, token, fileName, remoteNode, body = {})) and append it to the request URL as a query parameter (use encodeURIComponent on remoteNode) when calling request.post for /api/v1/dags/${encodeURIComponent(fileName)}/start; update any callers to pass the appropriate remoteNode value.
240-255: AddremoteNodequery parameter toenqueueDAGhelper.Per coding guidelines, all API calls must include the
remoteNodeparameter. This helper is missing it.♻️ Proposed fix
export async function enqueueDAG( request: APIRequestContext, token: string, fileName: string, - body: Record<string, unknown> = {} + body: Record<string, unknown> = {}, + remoteNode: string = 'local' ): Promise<string> { - const response = await request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/enqueue`, { + const response = await request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/enqueue?remoteNode=${encodeURIComponent(remoteNode)}`, { headers: authHeaders(token), data: body, });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/helpers/e2e.ts` around lines 240 - 255, The enqueueDAG helper is missing the required remoteNode query parameter; update the enqueueDAG function to accept a remoteNode string argument (or optional with default) and append ?remoteNode=${encodeURIComponent(remoteNode)} to the POST URL (i.e., call request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/enqueue?remoteNode=${encodeURIComponent(remoteNode)}`) ), leaving the authHeaders and body handling the same and returning payload.dagRunId as before; ensure any callers/tests are updated to pass the remoteNode value.
485-493:killProcessmay throw if process is already dead.The
execFileSynccall will throw an error if the process doesn't exist or is already terminated. Consider handling this case gracefully.🛡️ Proposed fix to handle already-dead processes
export async function killProcess( pid: number | string, signal: 'TERM' | 'KILL' = 'KILL' ): Promise<void> { - execFileSync('kill', [`-${signal}`, `${pid}`], { - cwd: repoRoot, - stdio: 'pipe', - }); + try { + execFileSync('kill', [`-${signal}`, `${pid}`], { + cwd: repoRoot, + stdio: 'pipe', + }); + } catch { + // Process may already be dead, which is acceptable + } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/helpers/e2e.ts` around lines 485 - 493, Wrap the execFileSync call in killProcess with a try/catch and swallow only the error that indicates the target process is already gone; detect that by checking the thrown error's exit code/message (e.g., exit status 1 or stderr containing "No such process"/ESRCH) and return silently, but rethrow any other errors so genuine failures (permissions, unexpected failures) are not masked; keep the function signature and use existing symbols killProcess, execFileSync, repoRoot and signal to locate the change.ui/e2e/dag-run-actions.spec.ts (1)
1-14: Missing GPL v3 license header.Per coding guidelines, source files must have GPL v3 license headers managed via
make addlicense.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/dag-run-actions.spec.ts` around lines 1 - 14, This file is missing the GPL v3 license header; locate the top of the file (just above the first import, e.g. the line "import { expect, test } from '@playwright/test';") and add the standard GPL v3 header managed by the repository tooling by running the project helper to inject headers: run "make addlicense" (or apply the same header text if you must add manually), then commit the updated file so the license header appears before the imports.ui/e2e/distributed-stack.spec.ts (2)
40-44: Consider escaping regex special characters in queue name.The static analysis tool flagged potential ReDoS risk when constructing a RegExp from variable input. While the queue name comes from controlled test configuration, escaping special regex characters would be safer practice.
🛡️ Proposed fix to escape regex special characters
+function escapeRegExp(str: string): string { + return str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); +} + const sharedQueueCard = page.getByRole('link', { - name: new RegExp(stack.queues.shared, 'i'), + name: new RegExp(escapeRegExp(stack.queues.shared), 'i'), });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/distributed-stack.spec.ts` around lines 40 - 44, The test constructs a RegExp from variable input (stack.queues.shared) which can introduce ReDoS or unintended regex behavior; update the page.getByRole call to use an escaped regex by first escaping regex metacharacters from stack.queues.shared (add or reuse a helper like escapeRegExp) and then build new RegExp(escapedName, 'i'), or alternatively pass the name as a plain string/match option instead of a RegExp; update references in distributed-stack.spec.ts around sharedQueueCard and the page.getByRole invocation to use the escaped value.
1-12: Missing GPL v3 license header.Per coding guidelines, source files must have GPL v3 license headers managed via
make addlicense.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/distributed-stack.spec.ts` around lines 1 - 12, The file distributed-stack.spec.ts is missing the required GPL v3 license header; add the standard GPL v3 header used across the repo to the very top of the file (above the import statements that include expect and test), and then run the repository license tool to apply/verify it by executing make addlicense so the header is managed consistently with other files.ui/e2e/worker-failover.spec.ts (1)
1-16: Missing GPL v3 license header.Per coding guidelines, source files must have GPL v3 license headers managed via
make addlicense.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/worker-failover.spec.ts` around lines 1 - 16, The file is missing the GPL v3 license header; add the standard GPL v3 comment block at the very top of the file (above the first import line such as "import { expect, test } from '@playwright/test'") to match repo style, preferably by running the repository tool to apply headers (run make addlicense) or by pasting the exact project GPL v3 header manually so it matches other test files.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ui/e2e/remote-nodes.spec.ts`:
- Line 1: This file remote-nodes.spec.ts is missing the required GPL v3 license
header; add the repository's standard GPL v3 comment block at the very top of
remote-nodes.spec.ts (matching the format used in other .ts/.tsx/.js files) or
run the repo tool to apply it by executing make addlicense so the correct header
is inserted consistently across the codebase.
- Around line 47-54: The expect.poll call that checks the remote DAG readiness
lacks an explicit timeout; update the expect.poll invocation in
remote-nodes.spec.ts (the block using expect.poll(async () => { const response =
await
request.get(`${stack.remote.apiBaseURL}/dags/${encodeURIComponent(remoteFileName)}`);
return response.ok(); })) to pass an options object with timeout: 15000
(matching the local DAG wait) so the poll will wait up to 15 seconds for
readiness in slower CI environments.
In `@ui/e2e/zombie-recovery.spec.ts`:
- Line 1: This file is missing the required GPL v3 license header; add the
standard GPL v3 header comment block at the top of
ui/e2e/zombie-recovery.spec.ts (above the import line) as used across the repo
and then run the repository's license tooling (e.g., make addlicense) to ensure
formatting/metadata matches other TypeScript files; reference this change for
the new test in zombie-recovery.spec.ts so the header appears before any code
(imports or tests).
In `@ui/playwright.config.ts`:
- Line 1: This file is missing the required GPL v3 license header; add the
standard GPL v3 header comment block to the top of ui/playwright.config.ts above
the existing import statement (the line containing "import { defineConfig,
devices } from '@playwright/test';"), then run the repository license tool
(e.g., make addlicense) to ensure the header is applied consistently to this and
other .ts/.tsx/.js/.go files.
---
Nitpick comments:
In `@Makefile`:
- Around line 362-364: The test-e2e target duplicates the asset copy steps;
remove the explicit "@rm -f ${FE_ASSETS_DIR}/*" and "@cp ${FE_BUILD_DIR}/*
${FE_ASSETS_DIR}" lines and instead invoke the existing cp-assets target (e.g.,
call "$(MAKE) cp-assets" or add cp-assets as a prerequisite for the test-e2e
recipe) so asset copying is centralized in the cp-assets target.
In `@ui/e2e/auth-permissions.spec.ts`:
- Around line 73-79: The POST call that sets startResponse (request.post in the
test) is missing the required remoteNode query parameter; update the request URL
used in the request.post for
`/api/v1/dags/${encodeURIComponent(fileName)}/start` to include
`?remoteNode=<nodeId>` (or interpolate the test's existing remote node variable)
so the call routes correctly, and keep the existing headers/authorization
(Authorization: `Bearer ${viewerToken}`) and data payload unchanged.
- Around line 1-11: The file auth-permissions.spec.ts is missing the GPL v3
license header; run the repository license tool (make addlicense) or insert the
GPL v3 header at the top of the file so the header precedes the imports (ensure
it appears before the import lines referencing helpers like createUser,
loginViaAPI, loginViaUI, uniqueName, etc.), then commit the updated file so the
test uses the standard license header.
In `@ui/e2e/dag-run-actions.spec.ts`:
- Around line 1-14: This file is missing the GPL v3 license header; locate the
top of the file (just above the first import, e.g. the line "import { expect,
test } from '@playwright/test';") and add the standard GPL v3 header managed by
the repository tooling by running the project helper to inject headers: run
"make addlicense" (or apply the same header text if you must add manually), then
commit the updated file so the license header appears before the imports.
In `@ui/e2e/distributed-stack.spec.ts`:
- Around line 40-44: The test constructs a RegExp from variable input
(stack.queues.shared) which can introduce ReDoS or unintended regex behavior;
update the page.getByRole call to use an escaped regex by first escaping regex
metacharacters from stack.queues.shared (add or reuse a helper like
escapeRegExp) and then build new RegExp(escapedName, 'i'), or alternatively pass
the name as a plain string/match option instead of a RegExp; update references
in distributed-stack.spec.ts around sharedQueueCard and the page.getByRole
invocation to use the escaped value.
- Around line 1-12: The file distributed-stack.spec.ts is missing the required
GPL v3 license header; add the standard GPL v3 header used across the repo to
the very top of the file (above the import statements that include expect and
test), and then run the repository license tool to apply/verify it by executing
make addlicense so the header is managed consistently with other files.
In `@ui/e2e/helpers/e2e.ts`:
- Around line 1-4: This file is missing the GPL v3 license header; add the
standard GPL v3 header comment at the very top of the file (above the existing
import lines such as "import { expect... }" and other imports) by running the
repository license tool (make addlicense) or inserting the canonical GPL v3
header, then stage/commit the change so the file includes the required license
header.
- Around line 223-238: The startDAG helper is missing the required remoteNode
query parameter; modify the startDAG function signature to accept a remoteNode:
string parameter (e.g., startDAG(request, token, fileName, remoteNode, body =
{})) and append it to the request URL as a query parameter (use
encodeURIComponent on remoteNode) when calling request.post for
/api/v1/dags/${encodeURIComponent(fileName)}/start; update any callers to pass
the appropriate remoteNode value.
- Around line 240-255: The enqueueDAG helper is missing the required remoteNode
query parameter; update the enqueueDAG function to accept a remoteNode string
argument (or optional with default) and append
?remoteNode=${encodeURIComponent(remoteNode)} to the POST URL (i.e., call
request.post(`/api/v1/dags/${encodeURIComponent(fileName)}/enqueue?remoteNode=${encodeURIComponent(remoteNode)}`)
), leaving the authHeaders and body handling the same and returning
payload.dagRunId as before; ensure any callers/tests are updated to pass the
remoteNode value.
- Around line 485-493: Wrap the execFileSync call in killProcess with a
try/catch and swallow only the error that indicates the target process is
already gone; detect that by checking the thrown error's exit code/message
(e.g., exit status 1 or stderr containing "No such process"/ESRCH) and return
silently, but rethrow any other errors so genuine failures (permissions,
unexpected failures) are not masked; keep the function signature and use
existing symbols killProcess, execFileSync, repoRoot and signal to locate the
change.
In `@ui/e2e/scheduler-recovery.spec.ts`:
- Around line 1-11: This file is missing the required GPL v3 license header; run
the repository tool to add it (execute `make addlicense`) or insert the standard
GPL v3 header at the top of the file so it precedes the imports (ensure it
appears above the existing symbols like listDAGRuns, loadStack, loginViaAPI,
startService, stopService, uniqueName, waitForRunStatus, writeLocalDAG), then
commit the updated file.
In `@ui/e2e/worker-failover.spec.ts`:
- Around line 1-16: The file is missing the GPL v3 license header; add the
standard GPL v3 comment block at the very top of the file (above the first
import line such as "import { expect, test } from '@playwright/test'") to match
repo style, preferably by running the repository tool to apply headers (run make
addlicense) or by pasting the exact project GPL v3 header manually so it matches
other test files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e34b6dad-6a7b-4f19-a69c-4c616c7d819f
⛔ Files ignored due to path filters (1)
ui/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (15)
.gitignoreMakefilescripts/e2e/generate-dev-license.mjsscripts/e2e/start-stack.shui/e2e/auth-permissions.spec.tsui/e2e/dag-run-actions.spec.tsui/e2e/distributed-stack.spec.tsui/e2e/fixtures/dags/e2e-distributed-queue.yamlui/e2e/helpers/e2e.tsui/e2e/remote-nodes.spec.tsui/e2e/scheduler-recovery.spec.tsui/e2e/worker-failover.spec.tsui/e2e/zombie-recovery.spec.tsui/package.jsonui/playwright.config.ts
yottahmd
changed the title
Wait on final side-effect (sendCount) instead of intermediate step (appendMessages) to avoid asserting before flush completes.
Cover create, rename, delete, suspend/resume, and invalid-name validation for DAGs. Cover password change, admin password reset, and manager/operator role permission boundaries.
Replace self-signed ephemeral keypair approach with CI secret-based signing. Production binary now always uses hardcoded public key with no env var or build tag escape hatch. E2e tests sign JWTs using the real private key provided via DAGU_LICENSE_PRIVKEY_B64 secret.
Extract 32-byte seed from Go's 64-byte ed25519.PrivateKey format and import via JWK instead of raw DER.
Node.js requires both d (seed) and x (public key) fields for Ed25519 JWK private key import.
- pnpm/action-setup v5.0.0 → v6.0.0 - actions/upload-artifact v4.6.2 → v7.0.1
v6.0.0 breaks pnpm 10 lockfile parsing.
Collaborator
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
ui/e2e/helpers/e2e.ts (2)
505-520: Unnecessaryasynckeyword on synchronous function.
killProcessis markedasyncbut contains noawaitexpressions—it uses only synchronousexecFileSync. Theasynccan be removed.♻️ Remove unnecessary async
-export async function killProcess( +export function killProcess( pid: number | string, signal: 'TERM' | 'KILL' = 'KILL' -): Promise<void> { +): void { try {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/helpers/e2e.ts` around lines 505 - 520, The function killProcess is marked async but contains no await and only uses synchronous execFileSync; remove the unnecessary async modifier and change the signature from "export async function killProcess(pid: number | string, signal: 'TERM' | 'KILL' = 'KILL'): Promise<void>" to a plain synchronous declaration (e.g., "export function killProcess(...): void"), keeping the existing body and error handling (isNoSuchProcessError, repoRoot, execFileSync) unchanged so callers get the correct synchronous return type.
476-503: Consider removing unnecessaryasynckeyword.The
stopServiceandstartServicefunctions are markedasyncbut only use synchronousexecFileSynccalls. While this doesn't cause issues, it could be confusing.♻️ Optional: Remove async from sync functions
-export async function stopService( +export function stopService( serviceName: string, signal: 'TERM' | 'KILL' = 'TERM' -): Promise<void> { +): void { const stack = await loadStack();Note: If you keep
async, it's becauseloadStack()is async. The current implementation is actually correct since it awaitsloadStack(). Disregard this suggestion.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/e2e/helpers/e2e.ts` around lines 476 - 503, stopService and startService are marked async but only appear to do synchronous work; verify whether loadStack() remains asynchronous—if loadStack is synchronous remove the async keyword and the await and call loadStack() directly in stopService/startService, otherwise keep the async/await as-is; locate the functions stopService and startService and adjust the async/await usage accordingly (or leave them unchanged if loadStack() is async).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/e2e/generate-dev-license.mjs`:
- Around line 12-18: The code slices rawKey into seed and pub and constructs a
JWK without validating the decoded length; add a guard after decoding (rawKey,
used by rawKey.subarray, seed, pub and before createPrivateKey/privateKey) to
verify rawKey.length is at least 64 (or exactly 64 for strict validation) and
throw a clear, descriptive error if the environment value
(DAGU_LICENSE_PRIVKEY_B64) is malformed; return/exit early on failure so
createPrivateKey is never called with an invalid seed/pub pair.
In `@ui/e2e/scheduler-recovery.spec.ts`:
- Around line 30-51: The test uses a fixed 1_000ms sleep after writeLocalDAG
which causes flakiness; replace that sleep with a deterministic wait that polls
for the DAG to be indexed/ready (e.g., repeatedly call listDAGRuns(request,
token, dagName) or another DAG-ready API until it returns the expected
availability or a timeout), and only then call stopService('scheduler') and
proceed to the waitUntilDueMs/assertions; update the code around writeLocalDAG,
the current setTimeout call, and the point before stopService('scheduler') to
perform this polling with a sensible timeout and short interval.
---
Nitpick comments:
In `@ui/e2e/helpers/e2e.ts`:
- Around line 505-520: The function killProcess is marked async but contains no
await and only uses synchronous execFileSync; remove the unnecessary async
modifier and change the signature from "export async function killProcess(pid:
number | string, signal: 'TERM' | 'KILL' = 'KILL'): Promise<void>" to a plain
synchronous declaration (e.g., "export function killProcess(...): void"),
keeping the existing body and error handling (isNoSuchProcessError, repoRoot,
execFileSync) unchanged so callers get the correct synchronous return type.
- Around line 476-503: stopService and startService are marked async but only
appear to do synchronous work; verify whether loadStack() remains
asynchronous—if loadStack is synchronous remove the async keyword and the await
and call loadStack() directly in stopService/startService, otherwise keep the
async/await as-is; locate the functions stopService and startService and adjust
the async/await usage accordingly (or leave them unchanged if loadStack() is
async).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 74d980fd-3a0a-4319-97b0-978eaa4fed7b
⛔ Files ignored due to path filters (1)
ui/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
.github/workflows/e2e-ci.yaml.gitignoreMakefileinternal/license/pubkey.gointernal/license/pubkey_dev.gointernal/service/telegram/bot_test.goscripts/e2e/generate-dev-license.mjsscripts/e2e/start-stack.shui/e2e/auth-flows.spec.tsui/e2e/auth-permissions.spec.tsui/e2e/dag-crud.spec.tsui/e2e/dag-run-actions.spec.tsui/e2e/distributed-stack.spec.tsui/e2e/fixtures/dags/e2e-distributed-queue.yamlui/e2e/helpers/e2e.tsui/e2e/remote-nodes.spec.tsui/e2e/scheduler-recovery.spec.tsui/e2e/worker-failover.spec.tsui/e2e/zombie-recovery.spec.tsui/package.jsonui/playwright.config.tsui/src/features/dags/components/common/CreateDAGButton.tsxui/src/features/dags/components/common/CreateDAGModal.tsxui/src/features/dags/components/dag-editor/DAGEditButtons.tsxui/src/features/dags/components/dag-editor/DAGSpec.tsx
💤 Files with no reviewable changes (2)
- internal/license/pubkey.go
- internal/license/pubkey_dev.go
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin-e2e,make test-e2e, and stack bootstrap underscripts/e2e/Test plan
make test-e2ecd ui && pnpm typecheckcd ui && pnpm playwright test e2e/dag-run-actions.spec.ts e2e/scheduler-recovery.spec.ts e2e/worker-failover.spec.ts e2e/zombie-recovery.spec.ts --project chromiumSummary by CodeRabbit
Tests
Chores
UI