internal/service/frontend/api/v1/dagruns.go (1)

2207-2254: Routing logic change looks correct for the PR objective.

The switch from WorkerID != "" to ShouldDispatchToCoordinator(dag, ...) correctly determines the stop path based on DAG definition properties (ForceLocal, WorkerSelector) and execution mode rather than a potentially stale WorkerID in saved status.

However, lines 2222-2227 contain dead code:

if a.coordinatorCli == nil {
    return nil, &Error{
        HTTPStatus: http.StatusServiceUnavailable,
        Code:       api.ErrorCodeInternalError,
        Message:    "coordinator not configured for distributed DAG cancellation",
    }
}

Per the ShouldDispatchToCoordinator implementation (context snippet 1, lines 11-13), the function returns false when !hasCoordinator. Since you pass a.coordinatorCli != nil as hasCoordinator, if ShouldDispatchToCoordinator returns true, then a.coordinatorCli is guaranteed non-nil. This nil check can never be true.

🔧 Optional: Remove dead code

 		if core.ShouldDispatchToCoordinator(dag, a.coordinatorCli != nil, a.defaultExecMode) {
 			// For distributed DAGs, use saved status for running check
 			if savedStatus.Status != core.Running {
 				return nil, &Error{
 					HTTPStatus: http.StatusBadRequest,
 					Code:       api.ErrorCodeNotRunning,
 					Message:    "DAG is not running",
 				}
 			}
-			// Send cancel request via coordinator
-			if a.coordinatorCli == nil {
-				return nil, &Error{
-					HTTPStatus: http.StatusServiceUnavailable,
-					Code:       api.ErrorCodeInternalError,
-					Message:    "coordinator not configured for distributed DAG cancellation",
-				}
-			}
 			if err := a.coordinatorCli.RequestCancel(ctx, request.Name, request.DagRunId, nil); err != nil {
 				return nil, fmt.Errorf("error requesting cancel: %w", err)
 			}
 		} else {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/service/frontend/api/v1/dagruns.go` around lines 2207 - 2254, The
nil-check block that returns ServiceUnavailable is dead code because
ShouldDispatchToCoordinator(dag, a.coordinatorCli != nil, a.defaultExecMode)
guarantees a.coordinatorCli is non-nil when it returns true; remove the if
a.coordinatorCli == nil { ... } block (the ServiceUnavailable Error return) from
the coordinator branch so the code proceeds directly to calling
a.coordinatorCli.RequestCancel(ctx, request.Name, request.DagRunId, nil) (keep
RequestCancel error handling as-is).