fix: improve git sync publish and filtering#1971
Merged
Conversation
📝 WalkthroughWalkthroughThe change introduces conflict-aware force-publish functionality to the git-sync module. A new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ui/src/pages/git-sync/index.tsx`:
- Around line 553-557: The modal can submit a hidden stale publishForce value
when the selected item's status changes; ensure publishForce cannot be sent
unless the item is currently in conflict by: when computing
publishItemStatus/canForcePublish (using publishModal and
rowByID.get(...).item.status), clear or set publishModal.publishForce to false
whenever canForcePublish is false, and also guard the publish submission logic
to only include publishForce in the payload if canForcePublish is true (i.e.,
check canForcePublish before reading publishModal.publishForce in the submit
handlers that build the publish request).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5a5a85d6-1486-4eb8-ad40-edf755c90a12
📒 Files selected for processing (1)
ui/src/pages/git-sync/index.tsx
yottahmd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DAGsand remove the aggregateAlltabWhy
The git sync page had a few usability and correctness gaps:
Unpublishedbecause staleuntrackedstate was never promoted tosyncedafter publish/pullAlltype tab was less useful than landing directly on the primaryDAGsviewTesting
go test ./internal/gitsync -count=1pnpm typecheckinui/ui/src/pages/queues/index.tsx:125(Cannot find namecomponents``)