fix: stop dashboard and cockpit dag run refetch loop#1954
Merged
Conversation
📝 WalkthroughWalkthroughRefactored DAG run query handling to use memoized query objects and stable query keys instead of inline construction. Added helper functions to normalize and sort query parameters, enabling semantic equivalence checking. Updated Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ui/src/features/dag-runs/hooks/__tests__/useExactDAGRuns.test.tsx (1)
1-4: Missing GPL v3 license header.Per coding guidelines, source files should include GPL v3 license headers. Run
make addlicenseto add the required header.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/src/features/dag-runs/hooks/__tests__/useExactDAGRuns.test.tsx` around lines 1 - 4, The file is missing the required GPL v3 license header; add the standard GPL v3 header comment to the top of the test file (the file containing useExactDAGRuns.test.tsx which tests useExactDAGRuns and imports DAGRunListQuery) — run the repository helper (make addlicense) or insert the canonical GPL v3 header block as used across the project so the file matches other sources and CI/license checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ui/src/features/dag-runs/hooks/__tests__/useExactDAGRuns.test.tsx`:
- Around line 1-4: The file is missing the required GPL v3 license header; add
the standard GPL v3 header comment to the top of the test file (the file
containing useExactDAGRuns.test.tsx which tests useExactDAGRuns and imports
DAGRunListQuery) — run the repository helper (make addlicense) or insert the
canonical GPL v3 header block as used across the project so the file matches
other sources and CI/license checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c6b5ed06-0e25-48b0-af84-cfb5bb52a8e2
📒 Files selected for processing (4)
ui/src/features/cockpit/hooks/useDateKanbanData.tsui/src/features/dag-runs/hooks/__tests__/useExactDAGRuns.test.tsxui/src/features/dag-runs/hooks/dagRunPagination.tsui/src/pages/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make fmtcd ui && pnpm exec vitest run src/features/dag-runs/hooks/__tests__/useExactDAGRuns.test.tsxcd ui && pnpm typecheckSummary by CodeRabbit
Refactor
Tests