feat: show next scheduled dag run in details#1953
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR adds a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ui/src/features/dags/components/dag-editor/DAGAttributes.tsx (1)
70-71: Align the new “Next run” text with the project color hierarchy tokens.The newly added block uses semantic foreground tokens rather than the repo’s explicit slate hierarchy rule.
🎨 Suggested adjustment
- <div className="text-sm text-muted-foreground"> - <span className="font-medium text-foreground">Next run:</span>{' '} + <div className="text-sm text-slate-600 dark:text-slate-400"> + <span className="font-medium text-slate-800 dark:text-slate-200">Next run:</span>{' '}As per coding guidelines, "Use text color hierarchy with primary text as
text-slate-800 dark:text-slate-200, secondary astext-slate-600 dark:text-slate-400, and muted astext-slate-500 dark:text-slate-500."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/src/features/dags/components/dag-editor/DAGAttributes.tsx` around lines 70 - 71, Replace the semantic tokens with the repo's explicit slate hierarchy in DAGAttributes.tsx: change the outer div's "text-sm text-muted-foreground" to the muted token "text-slate-500 dark:text-slate-500", and change the label span's "font-medium text-foreground" to the primary token "font-medium text-slate-800 dark:text-slate-200" (leave any following value text as muted/secondary as appropriate, e.g., "text-slate-600 dark:text-slate-400"). Ensure you update the className on the div and the span where "Next run:" is rendered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ui/src/features/dags/components/dag-editor/DAGAttributes.tsx`:
- Around line 70-71: Replace the semantic tokens with the repo's explicit slate
hierarchy in DAGAttributes.tsx: change the outer div's "text-sm
text-muted-foreground" to the muted token "text-slate-500 dark:text-slate-500",
and change the label span's "font-medium text-foreground" to the primary token
"font-medium text-slate-800 dark:text-slate-200" (leave any following value text
as muted/secondary as appropriate, e.g., "text-slate-600 dark:text-slate-400").
Ensure you update the className on the div and the span where "Next run:" is
rendered.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e9b66b65-67aa-4f6c-8b9d-68d4171afafe
📒 Files selected for processing (7)
api/v1/api.gen.goapi/v1/api.yamlinternal/service/frontend/api/v1/dags.gointernal/service/frontend/api/v1/dags_internal_test.goui/src/api/v1/schema.tsui/src/features/dags/components/dag-editor/DAGAttributes.tsxui/src/features/dags/components/dag-editor/__tests__/DAGAttributes.test.tsx
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
+ Coverage 67.96% 67.98% +0.01%
==========================================
Files 475 475
Lines 61304 61304
==========================================
+ Hits 41668 41679 +11
+ Misses 15660 15654 -6
+ Partials 3976 3971 -5 see 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
1 participant
Summary
nextRundata to DAG detail and spec API responsesTesting
go test ./internal/service/frontend/api/v1 -run 'Test(ListDAGsDataPreservesNextRunAcrossSSEPath|GetDAGDetailsAndSpecIncludeNextRun)$' -count=1cd ui && pnpm test src/features/dags/components/dag-editor/__tests__/DAGAttributes.test.tsx src/features/dags/components/dag-details/__tests__/DAGStatusOverview.test.tsxCloses #1950
Summary by CodeRabbit