fix(ui): enable live updates for Yesterday section in cockpit#1825
Merged
fix(ui): enable live updates for Yesterday section in cockpit#1825
Conversation
The cockpit only live-updated the Today section via SSE events, causing cross-midnight runs in the Yesterday section to show stale status. Split the live-update gate: isToday controls polling fallback, new isLive flag (Today + Yesterday) controls SSE event revalidation. Github-Issue: #1823
📝 WalkthroughWalkthroughThis change enables live updates for both the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ui/src/features/cockpit/hooks/useDateKanbanData.ts (1)
96-104: Query options still useisToday, limiting yesterday's update behavior.The SWR options are based on
isToday, so the yesterday section uses static options (refreshInterval: 0,revalidateOnFocus: false). If the intent is for yesterday to have similar live behavior to today, consider usingisLivehere as well:♻️ Suggested change
{ - ...(isToday + ...(isLive ? liveFallbackOptions(liveState) : { refreshInterval: 0,🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/src/features/cockpit/hooks/useDateKanbanData.ts` around lines 96 - 104, The SWR query options branch currently uses isToday to decide whether to call liveFallbackOptions(liveState) or use static options, which prevents yesterday from getting live behavior; update the conditional to use isLive (or include isLive in the condition) instead of isToday so that liveFallbackOptions(liveState) is applied whenever the date is live. Locate the ternary around liveFallbackOptions in useDateKanbanData.ts and replace the isToday check with isLive (or combine isToday || isLive) so that liveFallbackOptions(liveState) is returned for live dates and the static options remain for non-live dates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ui/src/features/cockpit/hooks/useDateKanbanData.ts`:
- Around line 96-104: The SWR query options branch currently uses isToday to
decide whether to call liveFallbackOptions(liveState) or use static options,
which prevents yesterday from getting live behavior; update the conditional to
use isLive (or include isLive in the condition) instead of isToday so that
liveFallbackOptions(liveState) is applied whenever the date is live. Locate the
ternary around liveFallbackOptions in useDateKanbanData.ts and replace the
isToday check with isLive (or combine isToday || isLive) so that
liveFallbackOptions(liveState) is returned for live dates and the static options
remain for non-live dates.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 11222c44-2acf-4942-b94e-cb01dca4eeb2
📒 Files selected for processing (3)
ui/src/features/cockpit/components/DateKanbanSection.tsxui/src/features/cockpit/components/__tests__/DateKanbanSection.test.tsxui/src/features/cockpit/hooks/useDateKanbanData.ts
yottahmd
deleted the
issue-1823-cockpit-should-live-update-yesterday-and
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLiveflag that is true for both Today and Yesterday dates, and passed it touseLiveDAGRunsinstead ofisTodaytodayStrusing a memoizeddayjscalculationisTodayandisLiveflags for today, yesterday, and older datesTesting
cd ui && pnpm test -- --run src/features/cockpit/components/__tests__/DateKanbanSection.test.tsxCloses #1823
Summary by CodeRabbit
Tests
Chores