ui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsPanel.tsx (1)

139-143: ⚠️ Potential issue | 🟠 Major

Avoid replacing panel content with LoadingIndicator on transient revalidation.

Line 139 now gates rendering on !data, so the panel can blank out and show a full loading indicator during updates/switches instead of retaining stale content.

💡 Proposed fix (keep last renderable data)

-  const data = isSubDAGRun ? subDAGQuery.data : dagRunQuery.data;
+  const data = isSubDAGRun ? subDAGQuery.data : dagRunQuery.data;
+  const lastDataRef = React.useRef<typeof data>(undefined);
+  if (data) {
+    lastDataRef.current = data;
+  }
+  const displayData = data ?? lastDataRef.current;
@@
-  if (!data) {
+  if (!displayData) {
     return (
       <div className="flex items-center justify-center h-full">
         <LoadingIndicator />
       </div>
     );
   }
@@
-            dagRun={data.dagRunDetails}
+            dagRun={displayData.dagRunDetails}

Based on learnings: Applies to ui/**/*.{ts,tsx} : "NEVER use full-page loading overlays or LoadingIndicator components that hide content; instead show stale data while fetching updates".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ui/src/features/dag-runs/components/dag-run-details/DAGRunDetailsPanel.tsx`
around lines 139 - 143, The component DAGRunDetailsPanel currently returns a
full-screen LoadingIndicator when data is falsy, causing the panel to blank
during transient revalidation; instead preserve and render the last known data
while fetching and only show the LoadingIndicator when there is genuinely no
prior data. Change the render guard around data in DAGRunDetailsPanel to keep
stale data: track previousData (via a useRef or useState) or use the query
hook's isLoading/isFetching flags, render previousData when data is undefined
but previousData exists, and only render the full LoadingIndicator when neither
data nor previousData exist; remove any logic that unmounts panel content on
transient revalidation.

ui/src/features/dags/components/dag-details/DAGDetailsPanel.tsx (1)

166-170: ⚠️ Potential issue | 🟠 Major

Do not replace the details panel with LoadingIndicator.

Line 169 hides panel content behind a loading state. Preserve stale content and use inline loading cues during refreshes instead of swapping out the panel.

As per coding guidelines ui/**/*.{ts,tsx}: “NEVER use full-page loading overlays or LoadingIndicator components that hide content; instead show stale data while fetching updates”.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ui/src/features/dags/components/dag-details/DAGDetailsPanel.tsx` around lines
166 - 170, The current DAGDetailsPanel returns a full-panel LoadingIndicator
when data?.dag is missing, which hides stale content; instead modify
DAGDetailsPanel to never replace the panel with a full-page loader—render the
existing panel UI even when data?.dag is undefined or being refreshed and show
inline refresh/loading cues (e.g., a small spinner or skeleton in the
header/fields) while fetching. Locate the early-return that checks data?.dag and
remove it; ensure the component renders the same container/structure and
conditionally displays inline loading state based on the fetch status (use the
existing data, a stale fallback, or isFetching flag) so the panel content
remains visible during updates.

ui/src/pages/dags/index.tsx (1)

314-348: ⚠️ Potential issue | 🟠 Major

Avoid hiding the panel behind LoadingIndicator on missing data.

Line 347 fully replaces the list content with a loading indicator. Keep stale/previous list content visible and use inline loading affordances instead of swapping out the panel content.

As per coding guidelines ui/**/*.{ts,tsx}: “NEVER use full-page loading overlays or LoadingIndicator components that hide content; instead show stale data while fetching updates”.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ui/src/pages/dags/index.tsx` around lines 314 - 348, The current conditional
replaces the entire panel with <LoadingIndicator /> when data is missing;
instead always render the existing panel (DAGErrors and DAGTable) and only show
an inline loading affordance when isLoading is true. Concretely, remove the
outer ternary that returns <LoadingIndicator /> and render DAGErrors and
DAGTable unconditionally (using data.dags || [] and data.errors || [] as now),
and add an inline spinner or disabled/loading state inside DAGTable or adjacent
to its header when isLoading is true; if data can be undefined during fetch,
keep previous data in local state (e.g., a retainedDags/ref) or render empty
arrays rather than hiding the panel so stale content remains visible while
fetching.