Hi, I'm using Dagu on Windows and found that since PR #1877 the environment variables for running command are limited and it is inadequate for running even "git pull" command.
I would suggest additional environment variables in env_windows.go like following:
// Copyright (C) 2026 Yota Hamada
// SPDX-License-Identifier: GPL-3.0-or-later
//go:build windows
package config
import "strings"
// init populates the package's defaultWhitelist with common Windows environment
// variable names so they are treated as whitelisted on Windows builds.
// normalizeEnvKey converts to uppercase on Windows for case-insensitive matching.
// Windows environment variables are case-insensitive, but Go maps are not.
func normalizeEnvKey(key string) string {
return strings.ToUpper(key)
}
func init() {
// Windows-specific environment variables (all uppercase for case-insensitive matching)
for _, key := range []string{
"USERPROFILE", // Native Home
"SYSTEMROOT", // C:\Windows
"WINDIR", // Same as SystemRoot
"SYSTEMDRIVE", // C:
"COMSPEC", // cmd.exe
"PATHEXT", // .COM;.EXE;.BAT
"TEMP", // Temp dir
"TMP", // Temp dir
"PATH", // System path
"PSMODULEPATH", // PowerShell specific
"HOME", // Used by Go, Git, and ported tools
// == CHANGE BEGIN ==
// User profile paths used by Git Credential Manager, PowerShell
// modules, and most .NET/Windows tooling.
"APPDATA",
"LOCALAPPDATA",
// Identity vars needed by Windows Credential Manager and tools
// that resolve the current user.
"USERNAME",
"USERDOMAIN",
// Standard install/data roots referenced by many tools.
"PROGRAMFILES",
"PROGRAMFILES(X86)",
"PROGRAMDATA",
// SSH agent handoff so `git pull` over SSH can reach ssh-agent.
// Harmless when unset.
"SSH_AUTH_SOCK",
"SSH_AGENT_PID",
// == CHANGE END ==
// Docker daemon connection (used by Docker SDK's client.FromEnv)
"DOCKER_HOST", // Docker daemon address
"DOCKER_TLS_VERIFY", // Enable TLS verification
"DOCKER_CERT_PATH", // Path to TLS certificates
"DOCKER_API_VERSION", // Pin Docker API version
} {
defaultWhitelist[key] = true
}
}
What do you think?
Best,
Rux
Hi, I'm using Dagu on Windows and found that since PR #1877 the environment variables for running command are limited and it is inadequate for running even "git pull" command.
I would suggest additional environment variables in
env_windows.golike following:What do you think?
Best,
Rux