add validation

yottahmd · yottahmd · commit c4c8cf761a76 · 2025-12-07T04:22:32.000+09:00
diff --git a/internal/core/spec/builder.go b/internal/core/spec/builder.go
@@ -1319,14 +1319,26 @@ func buildContinueOn(_ StepBuildContext, def stepDef, step *core.Step) error {
 
 	case map[string]any:
 		// Object syntax with detailed configuration
-		if failure, ok := v["failure"].(bool); ok {
-			step.ContinueOn.Failure = failure
+		if val, exists := v["failure"]; exists {
+			b, ok := val.(bool)
+			if !ok {
+				return core.NewValidationError("continueOn.failure", val, ErrContinueOnFieldMustBeBool)
+			}
+			step.ContinueOn.Failure = b
 		}
-		if skipped, ok := v["skipped"].(bool); ok {
-			step.ContinueOn.Skipped = skipped
+		if val, exists := v["skipped"]; exists {
+			b, ok := val.(bool)
+			if !ok {
+				return core.NewValidationError("continueOn.skipped", val, ErrContinueOnFieldMustBeBool)
+			}
+			step.ContinueOn.Skipped = b
 		}
-		if markSuccess, ok := v["markSuccess"].(bool); ok {
-			step.ContinueOn.MarkSuccess = markSuccess
+		if val, exists := v["markSuccess"]; exists {
+			b, ok := val.(bool)
+			if !ok {
+				return core.NewValidationError("continueOn.markSuccess", val, ErrContinueOnFieldMustBeBool)
+			}
+			step.ContinueOn.MarkSuccess = b
 		}
 
 		exitCodes, err := parseIntOrArray(v["exitCode"])
diff --git a/internal/core/spec/builder_test.go b/internal/core/spec/builder_test.go
@@ -1351,6 +1351,48 @@ steps:
 		assert.Equal(t, []int{1, 2, 3}, th.Steps[0].ContinueOn.ExitCode)
 		assert.True(t, th.Steps[0].ContinueOn.MarkSuccess)
 	})
+	t.Run("ContinueOnInvalidFailureType", func(t *testing.T) {
+		t.Parallel()
+
+		data := []byte(`
+steps:
+  - command: "echo 1"
+    continueOn:
+      failure: "true"
+`)
+		_, err := spec.LoadYAML(context.Background(), data)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "continueOn.failure")
+		assert.Contains(t, err.Error(), "boolean")
+	})
+	t.Run("ContinueOnInvalidSkippedType", func(t *testing.T) {
+		t.Parallel()
+
+		data := []byte(`
+steps:
+  - command: "echo 1"
+    continueOn:
+      skipped: 1
+`)
+		_, err := spec.LoadYAML(context.Background(), data)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "continueOn.skipped")
+		assert.Contains(t, err.Error(), "boolean")
+	})
+	t.Run("ContinueOnInvalidMarkSuccessType", func(t *testing.T) {
+		t.Parallel()
+
+		data := []byte(`
+steps:
+  - command: "echo 1"
+    continueOn:
+      markSuccess: "yes"
+`)
+		_, err := spec.LoadYAML(context.Background(), data)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "continueOn.markSuccess")
+		assert.Contains(t, err.Error(), "boolean")
+	})
 	t.Run("RetryPolicy", func(t *testing.T) {
 		t.Parallel()
 
diff --git a/internal/core/spec/errors.go b/internal/core/spec/errors.go
@@ -17,6 +17,7 @@ var (
 	ErrContinueOnOutputMustBeStringOrArray = errors.New("continueOn.output must be a string or an array of strings")
 	ErrContinueOnMustBeStringOrMap         = errors.New("continueOn must be a string ('skipped' or 'failed') or an object")
 	ErrContinueOnInvalidStringValue        = errors.New("continueOn string value must be 'skipped' or 'failed'")
+	ErrContinueOnFieldMustBeBool           = errors.New("value must be a boolean")
 	ErrInvalidSignal                       = errors.New("invalid signal")
 	ErrDependsMustBeStringOrArray          = errors.New("depends must be a string or an array of strings")
 	ErrExecutorTypeMustBeString            = errors.New("executor.type value must be string")
