improve params field

yottahmd · yottahmd · commit 967b558d63f8 · 2025-12-28T01:44:38.000+09:00
diff --git a/api/v2/api.gen.go b/api/v2/api.gen.go
diff --git a/api/v2/api.yaml b/api/v2/api.yaml
@@ -3057,7 +3057,7 @@ components:
           description: "RFC3339 timestamp when execution completed"
         params:
           type: string
-          description: "Parameters passed to the DAG"
+          description: "JSON-serialized parameters passed to the DAG"
 
     Node:
       type: object
diff --git a/internal/core/execution/outputs.go b/internal/core/execution/outputs.go
@@ -13,5 +13,5 @@ type OutputsMetadata struct {
 	AttemptID   string `json:"attemptId"`
 	Status      string `json:"status"`
 	CompletedAt string `json:"completedAt"`
-	Params      string `json:"params,omitempty"`
+	Params      string `json:"params,omitempty"` // JSON-serialized parameters
 }
diff --git a/internal/persistence/filedagrun/attempt_test.go b/internal/persistence/filedagrun/attempt_test.go
@@ -498,7 +498,7 @@ func TestAttempt_WriteOutputs(t *testing.T) {
 				AttemptID:   "attempt-1",
 				Status:      "succeeded",
 				CompletedAt: "2024-12-28T15:30:45Z",
-				Params:      "key=value",
+				Params:      `["key=value"]`,
 			},
 			Outputs: map[string]string{
 				"totalCount": "42",
diff --git a/internal/runtime/agent/agent.go b/internal/runtime/agent/agent.go
@@ -11,7 +11,6 @@ import (
 	"path/filepath"
 	"regexp"
 	"runtime/debug"
-	"strings"
 	"sync"
 	"sync/atomic"
 	"syscall"
@@ -686,14 +685,22 @@ func (a *Agent) buildOutputs(ctx context.Context, finalStatus core.Status) *exec
 		return nil
 	}
 
+	// Serialize params to JSON
+	var paramsJSON string
+	if len(a.dag.Params) > 0 {
+		if data, err := json.Marshal(a.dag.Params); err == nil {
+			paramsJSON = string(data)
+		}
+	}
+
 	return &execution.DAGRunOutputs{
 		Metadata: execution.OutputsMetadata{
 			DAGName:     a.dag.Name,
 			DAGRunID:    a.dagRunID,
 			AttemptID:   a.dagRunAttemptID,
 			Status:      finalStatus.String(),
 			CompletedAt: stringutil.FormatTime(time.Now()),
-			Params:      strings.Join(a.dag.Params, " "),
+			Params:      paramsJSON,
 		},
 		Outputs: outputs,
 	}
diff --git a/internal/service/frontend/api/v2/dagruns.go b/internal/service/frontend/api/v2/dagruns.go
@@ -365,7 +365,7 @@ func (a *API) GetDAGRunOutputs(ctx context.Context, request api.GetDAGRunOutputs
 			AttemptId:   outputs.Metadata.AttemptID,
 			Status:      api.StatusLabel(outputs.Metadata.Status),
 			CompletedAt: completedAt,
-			Params:      ptrOf(outputs.Metadata.Params),
+			Params:      &outputs.Metadata.Params,
 		},
 		Outputs: outputs.Outputs,
 	}, nil

Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,5 @@ type OutputsMetadata struct {`
`13`	`13`	AttemptID string `json:"attemptId"`
`14`	`14`	Status string `json:"status"`
`15`	`15`	CompletedAt string `json:"completedAt"`
`16`		- Params string `json:"params,omitempty"`
	`16`	+ Params string `json:"params,omitempty"` // JSON-serialized parameters
`17`	`17`	`}`