Skip to content

fix: remove patch in favor of skipTrailingSlashRedirect#20

Merged
salazarm merged 1 commit intodagster-io:masterfrom
styfle:fix-trailing-slash-to-handle-manually
Aug 2, 2023
Merged

fix: remove patch in favor of skipTrailingSlashRedirect#20
salazarm merged 1 commit intodagster-io:masterfrom
styfle:fix-trailing-slash-to-handle-manually

Conversation

@styfle
Copy link
Copy Markdown
Contributor

@styfle styfle commented Aug 2, 2023

This PR removes the patch to Next.js in favor of using the skipTrailingSlashRedirect config.

This disables the automatic normalization of href when using next/link (as well as the automatic server-side redirects) in favor of manually handling the trailing slash (meaning you need to add it manually to each href).

@salazarm
Copy link
Copy Markdown
Contributor

salazarm commented Aug 2, 2023

Cool this worked for me! thank you.

@salazarm salazarm merged commit 2e19838 into dagster-io:master Aug 2, 2023
@styfle styfle deleted the fix-trailing-slash-to-handle-manually branch August 2, 2023 22:53
@styfle
Copy link
Copy Markdown
Contributor Author

styfle commented Aug 2, 2023

@salazarm Great, thanks!

Would you mind updating the blog post to mention this since the patch is not needed?

https://dagster.io/blog/dbt-docs-on-react

@salazarm
Copy link
Copy Markdown
Contributor

salazarm commented Aug 3, 2023

Sure, btw I noticed that with SSG every prefetched page redownloads the same layout. Are there plans to optimize that?

@styfle
Copy link
Copy Markdown
Contributor Author

styfle commented Aug 4, 2023

Yes, there are plans to optimize that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants