Remove references to services in docker-compose down command test fixture#10042
Merged
Remove references to services in docker-compose down command test fixture#10042
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
dpeng817
changed the title
dpeng817
force-pushed
the
dpeng817/fix_test_fixture
branch
2 times, most recently
from
71ff4ed to
14ab365
Compare
dpeng817
force-pushed
the
dpeng817/fix_test_fixture
branch
from
14ab365 to
fabdedc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A recent change to docker-compose down errors on additional arguments that were previously ignored (docker/compose#9158). We had our docker-compose down setup to exactly mirror docker-compose up, which is incorrect in the exact way that it seems like this PR seeks to avoid confusion, so this PR gets rid of that parity in the command.
How I Tested These Changes
Previously got errors on local spindown when using docker-compose, this fixes.