ci: use prod dagger binary in universe tests#2495
Merged
shykes merged 1 commit intodagger:mainfrom May 21, 2022
Merged
Conversation
For reasons that are not clear to me at this time, when using the dagger-debug binary to run universe tests, the new yarn test is incredibly slow and usually times out after 30 minutes. But when using the default dagger binary, it's relatively fast. This needs to be understood better, but for now, running the universe tests with the default binary will unblock our CI (which currently fails on this yarn test consistently). Signed-off-by: Erik Sipsma <[email protected]>
shykes
approved these changes
May 21, 2022
Contributor
shykes
left a comment
shykes
left a comment
There was a problem hiding this comment.
Wow super weird, thank you for tracking this down!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons that are not clear to me at this time, when using the
dagger-debug binary to run universe tests, the new yarn test is
incredibly slow and usually times out after 30 minutes. But when using
the default dagger binary, it's relatively fast.
This needs to be understood better, but for now, running the universe
tests with the default binary will unblock our CI (which currently fails
on this yarn test consistently).
Signed-off-by: Erik Sipsma [email protected]
@shykes The timeout you were getting in your PR for the new yarn package has continued and is causing all PRs rebased on it to fail. After trying a few things I finally noticed that I could reproduce the timeout when I ran with the
dagger-debugbinary locally. This is really really weird to say the least, but switching to the normal binary at least unblocks CI for now. Obviously we need to follow up with looking into why this would happen.