ci: moving universe and docs integration tests to the dagger CI plan#2442
ci: moving universe and docs integration tests to the dagger CI plan#2442samalba merged 3 commits intodagger:mainfrom
Conversation
samalba
force-pushed
the
ci-integration
branch
5 times, most recently
from
9e0ecb5 to
80bb66a
Compare
|
The timeout you are getting in the universe tests should be fixed by this: #2495 |
samalba
force-pushed
the
ci-integration
branch
2 times, most recently
from
5c4ca04 to
afb7069
Compare
Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
samalba
changed the title
|
@sipsma Thanks for the review! Comparing the previous runs of integrations tests, looks like we took a 3x hit on performance for universe tests... I'll dig a bit deeper before we can merge this. You suggestion helped to prevent the timeout but it's still much slower than before, weird... |
Just re-ran the universe tests and they only took 6m, which is pretty good. I highly suspect what happened on the previous run was that we had too many tests running in parallel between this PR and others, which causes GHA cache to throttle us and take longer to download/upload cache. Issue for that here: #2365 The tracing I added to the integration tests let us 100% confirm that's what is happening, but I've held off on adding them to the universe tests just because there are several open PRs it would conflict with. So I can't be 100% sure that's what happened but feel fairly confident given the symptoms. Either way, I think this should be good to merge. |
samalba
changed the title
Thanks @sipsma, exactly what I needed to double check. |
3 participants
This is a follow-up of PR #2284
It adds integration tests for:
Closes #1522