ci: move integration tests from yarn to dagger plan#2284
Merged
samalba merged 9 commits intodagger:mainfrom May 7, 2022
Merged
ci: move integration tests from yarn to dagger plan#2284samalba merged 9 commits intodagger:mainfrom
samalba merged 9 commits intodagger:mainfrom
Conversation
bbc8daf to
a3f21ed
Compare
218c767 to
dab4447
Compare
Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
…tall Signed-off-by: Sam Alba <[email protected]>
…he tests directory Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
Signed-off-by: Sam Alba <[email protected]>
aluzzardi
reviewed
May 6, 2022
Contributor
|
Overall looks good -- left a few comments |
aluzzardi
reviewed
May 7, 2022
…r bin with -race Signed-off-by: Sam Alba <[email protected]>
aluzzardi
approved these changes
May 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./testsdir to the ci.cue dagger plan./tests) - only one test was using an external file, I had to disable itmake core-integration, we don't lose any performance (at least from my local tests)The next step is to port universe tests and find a way to parallelize without
parallel, it should speed things up.