Skip to content

ci: move integration tests from yarn to dagger plan#2284

Merged
samalba merged 9 commits intodagger:mainfrom
samalba:ci-integration
May 7, 2022
Merged

ci: move integration tests from yarn to dagger plan#2284
samalba merged 9 commits intodagger:mainfrom
samalba:ci-integration

Conversation

@samalba
Copy link
Copy Markdown
Contributor

@samalba samalba commented Apr 22, 2022

  • This PR moves all the bats tests in the ./tests dir to the ci.cue dagger plan
  • Yarn is not needed anymore
  • It adds a new constraint which is that all integration tests must be self-contained (cannot call files outside of ./tests) - only one test was using an external file, I had to disable it
  • The speed is the same as make core-integration, we don't lose any performance (at least from my local tests)

The next step is to port universe tests and find a way to parallelize without parallel, it should speed things up.

@samalba samalba force-pushed the ci-integration branch 2 times, most recently from bbc8daf to a3f21ed Compare April 25, 2022 23:03
@samalba samalba force-pushed the ci-integration branch 5 times, most recently from 218c767 to dab4447 Compare May 5, 2022 22:11
@samalba samalba marked this pull request as ready for review May 5, 2022 23:01
@samalba samalba requested a review from a team as a code owner May 5, 2022 23:01
@samalba samalba changed the title CI: move integration tests from yarn to dagger plan ci: move integration tests from yarn to dagger plan May 5, 2022
@aluzzardi
Copy link
Copy Markdown
Contributor

Overall looks good -- left a few comments

@samalba samalba requested a review from aluzzardi May 7, 2022 00:56
@samalba samalba merged commit 86fce36 into dagger:main May 7, 2022
@samalba samalba deleted the ci-integration branch May 7, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants