Conversation
helderco
force-pushed
the
decodesecret-type
branch
3 times, most recently
from
c4dcc2d to
cdc17a8
Compare
|
Not sure what's wrong. Fixes the linked issue but tests are failing with "secret not set" and I don't know why yet. Tested type with https://cuelang.org/play/?id=-n61uazTm6r#cue@export@json |
|
Is there anything obviously wrong to you @jlongtine @aluzzardi @shykes? I can't see it either @helderco 🤔 |
|
What's happening is that the output disjunction isn't being resolved when using this fix in some cases. It works for #1867, but breaks in some other tests, e.g., The difference may be because of the contents of the encrypted yaml file, wether it has nested keys or not. |
This is a workaround until we get a better solution from upstream. Signed-off-by: Helder Correia <[email protected]>
helderco
force-pushed
the
decodesecret-type
branch
from
cdc17a8 to
cb8ad64
Compare
|
This is a workaround just to unblock, until we have a better solution. Needed for #2265 as well. |
jlongtine
left a comment
jlongtine
left a comment
There was a problem hiding this comment.
Not my favorite change (I'd prefer we keep the schema...) but given the constraints, I think we should move forward with this for now.
4 participants
Fixes #1867
Signed-off-by: Helder Correia