Closed
Conversation
✅ Deploy Preview for devel-docs-dagger-io ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jlongtine
force-pushed
the
action-input-flags
branch
2 times, most recently
from
e579c69 to
4035cc9
Compare
marcosnils
reviewed
Mar 29, 2022
Signed-off-by: Joel Longtine <[email protected]>
jlongtine
force-pushed
the
action-input-flags
branch
from
4035cc9 to
fc0188e
Compare
gerhard
changed the title
dagger do action options flagsdagger do action options flags
aluzzardi
reviewed
Mar 31, 2022
| targetPath := getTargetPath(cmd.Flags().Args()) | ||
|
|
||
| daggerPlan, err := loadPlan(viper.GetString("plan")) | ||
| if err != nil && !viper.GetBool("help") { |
Contributor
There was a problem hiding this comment.
I'm surprised help is a catchable flag -- I thought that's why we had to use SetHelpFunc in the first place?
Contributor
Author
There was a problem hiding this comment.
Pretty sure it's only catchable because I set DisableFlagParsing: true
Contributor
Author
|
So... I can't update this PR because the private -> public transition threw my fork off. So, I'm gonna go sort that out, then open a new PR. |
Contributor
Author
|
Transitioning to #2033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joel Longtine [email protected]