[Docs] Building container images#1708
[Docs] Building container images#1708gerhard merged 1 commit intodagger:mainfrom helderco:build-images-doc
Conversation
|
✔️ Deploy Preview for devel-docs-dagger-io ready! 🔨 Explore the source changes: a48d093 🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/6228df84d103510008a285e5 😎 Browse the preview: https://deploy-preview-1708--devel-docs-dagger-io.netlify.app |
|
Thank you @TomChv for the feedback 🙂 I didn't know how ready alpine and go were. I think I saw something to that extent, but didn't look further because I needed to get something out the door and got back to basics. I didn't test these as well, I just tried do convert from the Dockerfile examples in the Docker docs (see links in each section). But I want to fix this right away by implementing #1715. I want the examples to be as short as possible, but still, at first I tried adapting from my personal use cases, but later I found better to convert from Docker's own examples. For sure, using the packages from universe is my intention, it'll help keep them shorter. |
|
I really like the straightforward examples:
For the first two examples, I would use the For the third example, the official mysql image would be my suggestion. For the multi-stage example, I don't think that the |
I agree, it doesn't even have python, I just adapted from Docker docs, as I've said (https://docs.docker.com/develop/develop-images/dockerfile_best-practices/).
I wanted the official one too, but it doesn't have those env vars and so I adopted one of my actual use cases which is really simple. I'll see if I can do something that makes sense with the official image.
Again, that was straight from Docker docs (https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds). I wanted to make it simpler so I'm refactoring with go and alpine packages from universe, abandoning the direct conversion from Docker docs, and just making it a simple go building example. Initially I was using one of my own cases with a base image that produces a build image and a run image, but this Go example is simpler. |
|
@gerhard updated |
|
I'm going to remove the platform targeting, because I crossed my wires. It's useful if you want that built binary in your local machine, but that's another use case. |
Signed-off-by: Helder Correia <[email protected]>
Signed-off-by: Helder Correia