docker.#Build: support for nested builds#1468
Merged
aluzzardi merged 1 commit intodagger:mainfrom Jan 21, 2022
aluzzardi:nested-docker-build
Merged
docker.#Build: support for nested builds#1468aluzzardi merged 1 commit intodagger:mainfrom aluzzardi:nested-docker-build
aluzzardi merged 1 commit intodagger:mainfrom
aluzzardi:nested-docker-build
Conversation
|
✔️ Deploy Preview for devel-docs-dagger-io ready! 🔨 Explore the source changes: 2ce9934 🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/61e9f42bc40f5600082eca57 😎 Browse the preview: https://deploy-preview-1468--devel-docs-dagger-io.netlify.app |
Signed-off-by: Andrea Luzzardi <[email protected]>
Merged
jlongtine
approved these changes
Jan 20, 2022
Contributor
jlongtine
left a comment
jlongtine
left a comment
There was a problem hiding this comment.
Looks good, @aluzzardi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1466
Added a test (not sure where to put it for now so it's in
docker/test/nested-build-test.cue/cc @TomChv)/cc @helderco