src: rename the variable storing permission for child_process and worker

daeyeon · daeyeon · commit 72cab6703fee · 2023-05-05T23:52:22.000+09:00
Signed-off-by: Daeyeon Jeong &lt;daeyeon.dev@gmail.com&gt;
diff --git a/src/env.cc b/src/env.cc
@@ -796,10 +796,10 @@ Environment::Environment(IsolateData* isolate_data,
     // spawn/worker nor use addons unless explicitly allowed by the user
     if (!options_->allow_fs_read.empty() || !options_->allow_fs_write.empty()) {
       options_->allow_native_addons = false;
-      if (!options_->allow_child_process) {
+      if (options_->allow_child_process) {
         permission()->Apply("*", permission::PermissionScope::kChildProcess);
       }
-      if (!options_->allow_worker_threads) {
+      if (options_->allow_worker_threads) {
         permission()->Apply("*", permission::PermissionScope::kWorkerThreads);
       }
     }
diff --git a/src/permission/child_process_permission.cc b/src/permission/child_process_permission.cc
@@ -11,12 +11,12 @@ namespace permission {
 // Once denied, it's always denied
 void ChildProcessPermission::Apply(const std::string& allow,
                                    PermissionScope scope) {
-  deny_all_ = true;
+  is_all_allowed_ = true;
 }
 
 bool ChildProcessPermission::is_granted(PermissionScope perm,
                                         const std::string_view& param) {
-  return deny_all_ == false;
+  return is_all_allowed_;
 }
 
 }  // namespace permission
diff --git a/src/permission/child_process_permission.h b/src/permission/child_process_permission.h
@@ -17,7 +17,7 @@ class ChildProcessPermission final : public PermissionBase {
                   const std::string_view& param = "") override;
 
  private:
-  bool deny_all_;
+  bool is_all_allowed_{false};
 };
 
 }  // namespace permission
diff --git a/src/permission/worker_permission.cc b/src/permission/worker_permission.cc
@@ -10,12 +10,12 @@ namespace permission {
 // Currently, PolicyDenyWorker manage a single state
 // Once denied, it's always denied
 void WorkerPermission::Apply(const std::string& allow, PermissionScope scope) {
-  deny_all_ = true;
+  is_all_allowed_ = true;
 }
 
 bool WorkerPermission::is_granted(PermissionScope perm,
                                   const std::string_view& param) {
-  return deny_all_ == false;
+  return is_all_allowed_;
 }
 
 }  // namespace permission
diff --git a/src/permission/worker_permission.h b/src/permission/worker_permission.h
@@ -17,7 +17,7 @@ class WorkerPermission final : public PermissionBase {
                   const std::string_view& param = "") override;
 
  private:
-  bool deny_all_;
+  bool is_all_allowed_{false};
 };
 
 }  // namespace permission

Original file line number	Diff line number	Diff line change
`@@ -796,10 +796,10 @@ Environment::Environment(IsolateData* isolate_data,`
`796`	`796`	`// spawn/worker nor use addons unless explicitly allowed by the user`
`797`	`797`	`if (!options_->allow_fs_read.empty() \|\| !options_->allow_fs_write.empty()) {`
`798`	`798`	`options_->allow_native_addons = false;`
`799`		`- if (!options_->allow_child_process) {`
	`799`	`+ if (options_->allow_child_process) {`
`800`	`800`	`permission()->Apply("*", permission::PermissionScope::kChildProcess);`
`801`	`801`	`}`
`802`		`- if (!options_->allow_worker_threads) {`
	`802`	`+ if (options_->allow_worker_threads) {`
`803`	`803`	`permission()->Apply("*", permission::PermissionScope::kWorkerThreads);`
`804`	`804`	`}`
`805`	`805`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,12 @@ namespace permission {`
`11`	`11`	`// Once denied, it's always denied`
`12`	`12`	`void ChildProcessPermission::Apply(const std::string& allow,`
`13`	`13`	`PermissionScope scope) {`
`14`		`- deny_all_ = true;`
	`14`	`+ is_all_allowed_ = true;`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`bool ChildProcessPermission::is_granted(PermissionScope perm,`
`18`	`18`	`const std::string_view& param) {`
`19`		`- return deny_all_ == false;`
	`19`	`+ return is_all_allowed_;`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`} // namespace permission`
Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,12 @@ namespace permission {`
`10`	`10`	`// Currently, PolicyDenyWorker manage a single state`
`11`	`11`	`// Once denied, it's always denied`
`12`	`12`	`void WorkerPermission::Apply(const std::string& allow, PermissionScope scope) {`
`13`		`- deny_all_ = true;`
	`13`	`+ is_all_allowed_ = true;`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`bool WorkerPermission::is_granted(PermissionScope perm,`
`17`	`17`	`const std::string_view& param) {`
`18`		`- return deny_all_ == false;`
	`18`	`+ return is_all_allowed_;`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`} // namespace permission`