Repository navigation
Commit 3b6f2c1
daewoongoh
fix(task-title): address pre-merge review findings
- Check the effective title profile against the current organization
allow-list before each request; a prohibited profile gets only the
fallback title.
- Evict the cache in setAutoTitleIfAbsent only when the task file is
confirmed missing, so a read or parse error cannot let a stale save
overwrite a peer's fields.
- Generate titles for prompts of any length and use the first 42
characters of the prompt as the fallback, as issue Zoo-Code-Org#2333 specifies.
- Store only the task id, parent id, and profile for unscheduled
candidates, and drop them when the task leaves the stack.
- Strip markdown emphasis only around words so identifiers such as
snake_case and __init__.py stay intact.
- Add provider event-wiring tests and a SettingsView save test.1 parent 5fbe82d commit 3b6f2c1
9 files changed
Lines changed: 448 additions & 95 deletions
File tree
- src/core
- task-persistence
- __tests__
- task-title
- __tests__
- webview
- __tests__
- webview-ui/src/components/settings/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
74 | 76 | | |
75 | 77 | | |
76 | 78 | | |
| |||
1027 | 1029 | | |
1028 | 1030 | | |
1029 | 1031 | | |
1030 | | - | |
| 1032 | + | |
| 1033 | + | |
1031 | 1034 | | |
1032 | 1035 | | |
1033 | 1036 | | |
1034 | 1037 | | |
1035 | | - | |
1036 | | - | |
1037 | | - | |
1038 | | - | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
1039 | 1041 | | |
1040 | | - | |
1041 | | - | |
1042 | | - | |
| 1042 | + | |
| 1043 | + | |
1043 | 1044 | | |
1044 | 1045 | | |
1045 | 1046 | | |
| |||
1048 | 1049 | | |
1049 | 1050 | | |
1050 | 1051 | | |
1051 | | - | |
| 1052 | + | |
1052 | 1053 | | |
1053 | 1054 | | |
1054 | 1055 | | |
| |||
1064 | 1065 | | |
1065 | 1066 | | |
1066 | 1067 | | |
1067 | | - | |
1068 | | - | |
1069 | | - | |
1070 | | - | |
1071 | | - | |
1072 | | - | |
1073 | | - | |
| 1068 | + | |
| 1069 | + | |
1074 | 1070 | | |
1075 | 1071 | | |
1076 | 1072 | | |
| |||
1084 | 1080 | | |
1085 | 1081 | | |
1086 | 1082 | | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
1087 | 1112 | | |
1088 | 1113 | | |
1089 | 1114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
496 | 496 | | |
497 | 497 | | |
498 | 498 | | |
499 | | - | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
500 | 528 | | |
501 | | - | |
| 529 | + | |
| 530 | + | |
502 | 531 | | |
503 | 532 | | |
504 | | - | |
505 | | - | |
506 | | - | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
507 | 552 | | |
508 | 553 | | |
509 | 554 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
| 3 | + | |
10 | 4 | | |
11 | 5 | | |
12 | 6 | | |
| |||
30 | 24 | | |
31 | 25 | | |
32 | 26 | | |
| 27 | + | |
| 28 | + | |
33 | 29 | | |
34 | 30 | | |
35 | 31 | | |
| |||
63 | 59 | | |
64 | 60 | | |
65 | 61 | | |
66 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
| |||
162 | 168 | | |
163 | 169 | | |
164 | 170 | | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | 171 | | |
169 | 172 | | |
170 | 173 | | |
| |||
177 | 180 | | |
178 | 181 | | |
179 | 182 | | |
| 183 | + | |
| 184 | + | |
180 | 185 | | |
181 | 186 | | |
182 | | - | |
| 187 | + | |
| 188 | + | |
183 | 189 | | |
184 | 190 | | |
185 | | - | |
| 191 | + | |
186 | 192 | | |
187 | 193 | | |
188 | 194 | | |
| |||
0 commit comments