fix(createServer): use addHook instead of ready (redwoodjs#9871)

jtoar · web-flow · commit 49347fd79c14 · 2024-01-22T12:08:01.000-08:00
Fixes the issue @Tobbe and I were seeing in studio: ``` ~/redwood-project/node_modules/avvio/boot.js:244 throw new AVV_ERR_ROOT_PLG_BOOTED() ^ AvvioError [Error]: Root plugin has already booted ... ``` `fastify.ready` actually starts the server. All this is doing is logging. We want to use `addHook` instead. Follow up to redwoodjs#9845.
diff --git a/packages/api-server/src/plugins/graphql.ts b/packages/api-server/src/plugins/graphql.ts
@@ -115,14 +115,16 @@ export async function redwoodFastifyGraphQLServer(
       })
     }
 
-    fastify.ready(() => {
+    fastify.addHook('onReady', (done) => {
       console.info(`GraphQL Yoga Server endpoint at ${yoga.graphqlEndpoint}`)
       console.info(
         `GraphQL Yoga Server Health Check endpoint at ${yoga.graphqlEndpoint}/health`
       )
       console.info(
         `GraphQL Yoga Server Readiness endpoint at ${yoga.graphqlEndpoint}/readiness`
       )
+
+      done()
     })
 
     done()

Original file line number	Diff line number	Diff line change
`@@ -115,14 +115,16 @@ export async function redwoodFastifyGraphQLServer(`
`115`	`115`	`})`
`116`	`116`	`}`
`117`	`117`
`118`		`- fastify.ready(() => {`
	`118`	`+ fastify.addHook('onReady', (done) => {`
`119`	`119`	console.info(`GraphQL Yoga Server endpoint at ${yoga.graphqlEndpoint}`)
`120`	`120`	`console.info(`
`121`	`121`	`GraphQL Yoga Server Health Check endpoint at ${yoga.graphqlEndpoint}/health`
`122`	`122`	`)`
`123`	`123`	`console.info(`
`124`	`124`	`GraphQL Yoga Server Readiness endpoint at ${yoga.graphqlEndpoint}/readiness`
`125`	`125`	`)`
	`126`	`+`
	`127`	`+ done()`
`126`	`128`	`})`
`127`	`129`
`128`	`130`	`done()`