Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Thanks! I'll merge this in about a week or so. The grid lines have always been a bit of a weak point--I've never been able to get them exactly how I want them to look. Currently the grid is altitude/azimuth, because that was easiest to implement due to the fact that the grid is stationary. I think a equatorial grid would look a lot better, but haven't been able to figure out how to render one without basically building up a 2D ASCII rendering engine. I think the next step is to add altitude coordinates to the grid (concentric circles). Once those are added, it'd make sense to stop the azimuth grid lines from drawing close to the center because the density of grid lines there just cover everything up and look gross. |
Refactor: selection of grid line angles Co-authored-by: Dalton Luce <[email protected]>
yinghao-w
force-pushed
the
fix-draw-grid-SIGFPE
branch
from
b66b79c to
08cdf24
Compare
2 participants
Hello and thank you for this really fun program!
Fixes #73. For large resolutions the
step_sizesarray indexiwas decremented to-1, leading to0value and SIGFPE. Fix by incrementing instead. This does lead to less dense grid lines than before this change, but given the comment this seems like the intended behaviour.By the way are there any plans for more configurability of the grid lines?