Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: da-luce/astroterm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.7
Choose a base ref
...
head repository: da-luce/astroterm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.8
Choose a head ref
  • 6 commits
  • 14 files changed
  • 6 contributors

Commits on Feb 22, 2025

  1. doc: Add intallation note for Guix. (#74)

    * doc: Add intallation note for Guix.
    Hellseher authored Feb 22, 2025
    Configuration menu
    Copy the full SHA
    fef215d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2025

  1. doc: Fix typos (#76)

    Found via `codespell -S data,./test/third_party -L ded,nast` and `typos
    --hidden --format brief`
    kianmeng authored Jul 2, 2025
    Configuration menu
    Copy the full SHA
    1865c23 View commit details
    Browse the repository at this point in the history
  2. Bump ubuntu runner version (#83)

    * bump Ubuntu runner versions
    * remove Ubuntu dependency comment (at some point ubuntu-20.04 was required for builds to succeed?)
    da-luce authored Jul 2, 2025
    Configuration menu
    Copy the full SHA
    a91d909 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2025

  1. Configuration menu
    Copy the full SHA
    a9f8ff2 View commit details
    Browse the repository at this point in the history
  2. fix: Sort cities according to the normalization function used when se…

    …arching (#79)
    
    * Sort cities according to the normalization function used when searching
    
    A binary search is used to find the city specified with -i/--city.
    Therefore, the cities array must be sorted accordingly to the comparison
    function used in the binary search.
    
    The currently used comparison function normalizes city names. In
    particular, all names are lowercased, which impacts their
    lexicographical order.
    
    Because of this, the following example fails without this patch, even
    though "Rio de Janeiro" is in data/cities.csv.
    
        $ astroterm -mi "Rio de Janeiro"
        ERROR: Could not find city "Rio de Janeiro"
    
    To fix it, use the normalized city names when sorting them in
    filter_cities.py. The normalization should match the one used at
    runtime. Then regenerate data/cities.csv with:
    
    $ python scripts/filter_cities.py cities15000.txt  data/cities.csv 200000
    
    (cities15000.txt downloaded today from: https://download.geonames.org/export/dump/cities15000.zip)
    
    * test: Add test for PR #79 - normalized city name lookup
    
    ---------
    
    Co-authored-by: Dalton Luce <[email protected]>
    jonasmalacofilho and da-luce authored Jul 14, 2025
    Configuration menu
    Copy the full SHA
    be8e924 View commit details
    Browse the repository at this point in the history
  3. build: bump version to 1.0.8

    da-luce committed Jul 14, 2025
    Configuration menu
    Copy the full SHA
    6701a86 View commit details
    Browse the repository at this point in the history
Loading